Date: Mon, 1 May 2000 04:11:56 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <Pine.BSF.4.21.0005010354410.2953-100000@alphplex.bde.org> In-Reply-To: <200004301600.JAA18945@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 30 Apr 2000, Andrey A. Chernov wrote: > ache 2000/04/30 09:00:54 PDT > > Modified files: > sys/kern tty.c > Log: > Add sysctl variable to set initial drainwait timeout on ttyopen, default to > 5 minutes This is all very broken. It used to be possible to set the drainwait timeout using comcontrol and have the setting live across closes. /etc/rc.serial has examples of setting it. Now, the setting gets clobbered in ttyopen() not only for first opens, but for open of the termios line discipline, i.e., for every open(2) and for every reentry to the termios line discipline (TIOCSETD to TTYDISC). This bug was introduced in the previous commit. The sysctl just allows changing the default value that is used to clobber the setting. Sysctls shouldn't be used in device drivers. Here the default should only be used if the timeout has not already been set. Changing the default using sysctl will have little or no effect effect after the system has warmed up, since most or all ttys will have had their timeouts set. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0005010354410.2953-100000>