Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 03 Jun 2018 08:34:13 -0400
From:      Waitman Gobble <waitman@waitman.net>
To:        "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
Subject:   Re: Error build nvidia-driver with r334555
Message-ID:  <YZ4vHc55bQXSXHxReT7gqyZizwAF0AIe52xkSbWbd1Xlk8yOG8-TkyNBYCKmuzS1wMdjVn8D2Qwv_UB8St0YOfBglClg8QerNoqoeYUuGN8=@waitman.net>
In-Reply-To: <20180603122142.GM3789@kib.kiev.ua>
References:  <83fec8d8-699f-e86c-9884-9d8698a86a91@gmail.com> <20180603120834.GT1389@albert.catwhisker.org> <20180603122142.GM3789@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help



=E2=80=8B
=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me=
ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90

On June 3, 2018 8:21 AM, Konstantin Belousov <kostikbel@gmail.com> wrote:

> On Sun, Jun 03, 2018 at 05:08:34AM -0700, David Wolfskill wrote:
>=20
> > On Sun, Jun 03, 2018 at 06:48:01PM +0700, Alex V. Petrov wrote:
> >=20
> > > ....
> > >=20
> > > --- nvidia_subr.o ---
> > >=20
> > > nvidia_subr.c:367:26: error: 'memset' call operates on objects of typ=
e
> > >=20
> > > 'struct nv_ioctl_card_info' while the size is based on a different ty=
pe
> > >=20
> > > 'struct nv_ioctl_card_info *' [-Werror,-Wsizeof
> > >=20
> > > -pointer-memaccess]
> > >=20
> > > memset(ci, 0, sizeof(ci));
> > >=20
> > > ~~ ^~
> > >=20
> > > nvidia_subr.c:367:26: note: did you mean to dereference the argument =
to
> > >=20
> > > 'sizeof' (and multiply it by the number of elements)?
> > >=20
> > >     memset(ci, 0, sizeof(ci));
> > >                          ^~
> > >    =20
> > >=20
> > > 1 error generated.
> > >=20
> > > *** [nvidia_subr.o] Error code 1
> > >=20
> > > ....
> >=20
> > Aye; please ref.
> >=20
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228709 for
> >=20
> > additional details.
> >=20
> > The issue has been narrowed down to the range r334529 - r334535; I'm
> >=20
> > suspecting r334533 and/or r334534. (Not that the commits are in any way
> >=20
> > "faulty" -- merely that the nvidia-driver port may need some "evasive
> >=20
> > action" to allow for the change).
>=20
> Even not looking at the actual code, I am quite sure that the line
>=20
> nvidia_subr.c:367 should be changed to
>=20
> memset(ci, 0, sizeof(*ci));
>=20
> This is a bug in the driver sources.
>=20
> freebsd-current@freebsd.org mailing list
>=20
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
>=20
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org=
"



That solved the build problem for me.=20
I haven't noticed any other issues with nvidia driver.


Waitman Gobble

Sent with ProtonMail Secure Email.=E2=80=8B





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZ4vHc55bQXSXHxReT7gqyZizwAF0AIe52xkSbWbd1Xlk8yOG8-TkyNBYCKmuzS1wMdjVn8D2Qwv_UB8St0YOfBglClg8QerNoqoeYUuGN8=>