Date: Tue, 12 Feb 2013 00:52:36 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alexander Leidinger <netchild@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r312035 - head/audio/lame Message-ID: <CAF6rxg=n8C_pbegUHOs4J40RPQftEfnOKjYNiwSw_EbHevu%2B1Q@mail.gmail.com> In-Reply-To: <20130212050358.GA89487@FreeBSD.org> References: <201302101723.r1AHNtaU044891@svn.freebsd.org> <20130212050358.GA89487@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 February 2013 00:03, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sun, Feb 10, 2013 at 05:23:55PM +0000, Alexander Leidinger wrote: >> New Revision: 312035 >> URL: http://svnweb.freebsd.org/changeset/ports/312035 >> >> Log: >> Add dependency to libiconv. > > :) I would say adding USE_ICONV is probably useless in cases like this one, > when it's getting pulled via other stuff. If a port directly uses ICONV it must explicitly depend on it, and must not rely on indirect dependencies. As for a PORTREVISION bump, this is more interesting: I am inclined to bump because the "manifest" of the port changed. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=n8C_pbegUHOs4J40RPQftEfnOKjYNiwSw_EbHevu%2B1Q>