Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 Nov 2017 14:49:22 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r325395 - stable/11/usr.sbin/bsnmpd/modules/snmp_hostres
Message-ID:  <201711041449.vA4EnMBr001632@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Sat Nov  4 14:49:22 2017
New Revision: 325395
URL: https://svnweb.freebsd.org/changeset/base/325395

Log:
  MFC r325067:
  bsnmpd: Only refresh devtree if devd event is a new or removed device.
  
  It makes sense to refresh the tree only when a device is inserted or
  removed, otherwise bsnmpd needlessly wastes lots of CPU.
  
  PR:		209368

Modified:
  stable/11/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c
==============================================================================
--- stable/11/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c	Sat Nov  4 14:45:36 2017	(r325394)
+++ stable/11/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_device_tbl.c	Sat Nov  4 14:49:22 2017	(r325395)
@@ -479,7 +479,9 @@ again:
 	} else {
 		if (read_len == sizeof(buf))
 			goto again;
-		refresh_device_tbl(1);
+		/* Only refresh device table on a device add or remove event. */
+		if (buf[0] == '+' || buf[0] == '-')
+			refresh_device_tbl(1);
 	}
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711041449.vA4EnMBr001632>