Date: Wed, 11 Nov 2009 13:49:22 +0000 (UTC) From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r199183 - head/sys/kern Message-ID: <200911111349.nABDnMQh096358@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: trasz Date: Wed Nov 11 13:49:22 2009 New Revision: 199183 URL: http://svn.freebsd.org/changeset/base/199183 Log: Revert r198873. Having different VAPPEND semantics for VOP_ACCESS(9) and VOP_ACCESSX(9) is not a good idea. Modified: head/sys/kern/vfs_default.c Modified: head/sys/kern/vfs_default.c ============================================================================== --- head/sys/kern/vfs_default.c Wed Nov 11 12:55:58 2009 (r199182) +++ head/sys/kern/vfs_default.c Wed Nov 11 13:49:22 2009 (r199183) @@ -353,14 +353,6 @@ vop_stdaccessx(struct vop_accessx_args * if (accmode == 0) return (0); - /* - * Many VOP_APPEND implementations don't expect VAPPEND without VWRITE - * being set, e.g. they check whether the filesystem is read-only only - * when VWRITE is set. Make sure we don't confuse them. - */ - if (accmode & VAPPEND) - accmode |= VWRITE; - return (VOP_ACCESS(ap->a_vp, accmode, ap->a_cred, ap->a_td)); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911111349.nABDnMQh096358>