Date: Wed, 23 Jan 2008 11:31:51 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Rong-En Fan <rafan@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in Message-ID: <47979627.1060405@FreeBSD.org> In-Reply-To: <20080122215109.GD21985@tirith.brixandersen.dk> References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> <4795044E.6030006@FreeBSD.org> <20080122015108.GX4650@svm.csie.ntu.edu.tw> <20080122215109.GD21985@tirith.brixandersen.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Henrik Brix Andersen wrote:
> On Tue, Jan 22, 2008 at 09:51:08AM +0800, Rong-En Fan wrote:
>> On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote:
>>> The script looks good, thanks for doing this! The only thing I would point
>>> out is that the default _enable=no is not needed, since rc.subr needs to
>>> see one of the values for "yes" in order to do anything. No harm leaving it
>>> in, I just wanted to point out that it's not strictly necessary.
>> Thanks. I see most of our /etc/rc.d/* scripts does not have this.
>> But most ports' have as our Porter's Handbook have such example.
>
> I believe this is actually required for rc scripts supplied by
> ports. Scripts included in the base wont need it, since their default
> settings are already present in /etc/defaults/rc.conf.
>
> I just tried removing the default setting for '$bitlbee_enable' in the
> rc script for irc/bitlbee, I did recently. It then results in the
> following error when '$bitlbee_enable' is undefined:
>
> # /usr/local/etc/rc.d/bitlbee rcvar
> # bitlbee
> /usr/local/etc/rc.d/bitlbee: WARNING: $bitlbee_enable is not set properly - see rc.conf(5).
> bitlbee_enable=NO
Hrrm, that's annoying. :) Ignore what I said then, if it's doing that
(and I don't think it _should_, but that's another issue) then you need
the default. Sorry for the noise.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47979627.1060405>