Date: Sun, 22 Aug 2004 20:22:15 +0200 From: Stefan Walter <sw@gegenunendlich.de> To: Mark Russell <freebsd@mark.net.au>, ports@freebsd.org Subject: Re: ignoring FETCH_DEPENDS Message-ID: <20040822182215.GA20724@kyuzo.dunkelkammer.void> In-Reply-To: <20040823004314.E822@juana.isp.net.au> References: <20040822210254.F822@juana.isp.net.au> <20040822143708.GA29683@xor.obsecurity.org> <20040823004314.E822@juana.isp.net.au>
next in thread | previous in thread | raw e-mail | index | archive | help
--Fba/0zbH8Xs+Fj9o
Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw"
Content-Disposition: inline
--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Mark Russell in gmane.os.freebsd.devel.ports:
> The distfiles of the 2 ports concerned fetch fine without the=20
> FETCH_DEPENDS, the case of net/p5-Net-SSH-Perl it wants to install its=20
> BUILD_DEPENDS before it fetches, I've yet to work out why. The other port=
=20
It's a bug in the Makefile, it shouldn't have those FETCH_DEPENDS. Could
you try the attached patch? It
- removes the FETCH_DEPENDS.
- removes an unused variable.
- corrects a dependency on devel/p5-IO which is not necessary for recent
Perl versions.
The CVS logs say there were also problems with the package build on
bento. I was able to build a package without any problems, so I removed
NO_PACKAGE, too. Maybe that one's fixed now, too.
I haven't checked if the port already has dependencies for all the
algorithms/Perl modules you can choose in the interactive configure
script. I also guess that the plist is broken if you choose not to
install the SSH1 or SSH2 protocol module (the default is to install
both), but I haven't looked at that, yet.
I'll have a look at the rest tomorrow and then send a PR, unless someone
is faster or there is a problem with the patch.
Stefan
--=20
No reading beyond this point
--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="p5-Net-SSH-Perl.patch"
Content-Transfer-Encoding: quoted-printable
diff -urN p5-Net-SSH-Perl.old/Makefile p5-Net-SSH-Perl/Makefile
--- p5-Net-SSH-Perl.old/Makefile Sun Aug 22 18:47:13 2004
+++ p5-Net-SSH-Perl/Makefile Sun Aug 22 19:35:51 2004
@@ -15,28 +15,30 @@
MAINTAINER=3D jesper@FreeBSD.org
COMMENT=3D Perl5 module implements both the SSH1 and SSH2 protocols
=20
-NO_PACKAGE=3D "Runaway package build"
+PERL_CONFIGURE=3D yes
=20
-PERL_BASE=3D ${SITE_PERL}
-BUILD_DEPENDS=3D ${PERL_BASE}/Crypt/DSA.pm:${PORTSDIR}/security/p5-Crypt-D=
SA \
- ${PERL_BASE}/Crypt/DH.pm:${PORTSDIR}/security/p5-Crypt-DH \
- ${PERL_BASE}/${PERL_ARCH}/Math/Pari.pm:${PORTSDIR}/math/p5-Math-Pari \
- ${PERL_BASE}/${PERL_ARCH}/MIME/Base64.pm:${PORTSDIR}/converters/p5-MIME-=
Base64 \
- ${PERL_BASE}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-M=
D5 \
- ${PERL_BASE}/${PERL_ARCH}/Digest/SHA1.pm:${PORTSDIR}/security/p5-Digest-=
SHA1 \
- ${PERL_BASE}/Digest/HMAC_SHA1.pm:${PORTSDIR}/security/p5-Digest-HMAC \
- ${PERL_BASE}/Digest/HMAC_MD5.pm:${PORTSDIR}/security/p5-Digest-HMAC \
- ${PERL_BASE}/Convert/PEM.pm:${PORTSDIR}/converters/p5-Convert-PEM \
- ${PERL_BASE}/Digest/BubbleBabble.pm:${PORTSDIR}/security/p5-Digest-Bubbl=
eBabble \
- ${PERL_BASE}/Crypt/RSA.pm:${PORTSDIR}/security/p5-Crypt-RSA \
- ${PERL_BASE}/${PERL_ARCH}/IO/Socket.pm:${PORTSDIR}/devel/p5-IO \
- ${PERL_BASE}/${PERL_ARCH}/String/CRC32.pm:${PORTSDIR}/devel/p5-String-CR=
C32 \
- ${PERL_BASE}/${PERL_ARCH}/Math/GMP.pm:${PORTSDIR}/math/p5-Math-GMP \
- ${PERL_BASE}/${PERL_ARCH}/Crypt/IDEA.pm:${PORTSDIR}/security/p5-Crypt-ID=
EA
-RUN_DEPENDS=3D ${BUILD_DEPENDS}
-FETCH_DEPENDS=3D ${BUILD_DEPENDS}
+.include <bsd.port.pre.mk>
=20
-PERL_CONFIGURE=3D yes
+BUILD_DEPENDS=3D ${SITE_PERL}/Crypt/DSA.pm:${PORTSDIR}/security/p5-Crypt-D=
SA \
+ ${SITE_PERL}/Crypt/DH.pm:${PORTSDIR}/security/p5-Crypt-DH \
+ ${SITE_PERL}/${PERL_ARCH}/Math/Pari.pm:${PORTSDIR}/math/p5-Math-Pari \
+ ${SITE_PERL}/${PERL_ARCH}/MIME/Base64.pm:${PORTSDIR}/converters/p5-MIME-=
Base64 \
+ ${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-M=
D5 \
+ ${SITE_PERL}/${PERL_ARCH}/Digest/SHA1.pm:${PORTSDIR}/security/p5-Digest-=
SHA1 \
+ ${SITE_PERL}/Digest/HMAC_SHA1.pm:${PORTSDIR}/security/p5-Digest-HMAC \
+ ${SITE_PERL}/Digest/HMAC_MD5.pm:${PORTSDIR}/security/p5-Digest-HMAC \
+ ${SITE_PERL}/Convert/PEM.pm:${PORTSDIR}/converters/p5-Convert-PEM \
+ ${SITE_PERL}/Digest/BubbleBabble.pm:${PORTSDIR}/security/p5-Digest-Bubbl=
eBabble \
+ ${SITE_PERL}/Crypt/RSA.pm:${PORTSDIR}/security/p5-Crypt-RSA \
+ ${SITE_PERL}/${PERL_ARCH}/String/CRC32.pm:${PORTSDIR}/devel/p5-String-CR=
C32 \
+ ${SITE_PERL}/${PERL_ARCH}/Math/GMP.pm:${PORTSDIR}/math/p5-Math-GMP \
+ ${SITE_PERL}/${PERL_ARCH}/Crypt/IDEA.pm:${PORTSDIR}/security/p5-Crypt-ID=
EA
+
+.if ${PERL_LEVEL} <=3D 500600
+BUILD_DEPENDS+=3D ${SITE_PERL}/${PERL_ARCH}/IO/Socket.pm:${PORTSDIR}/devel=
/p5-IO
+.endif
+
+RUN_DEPENDS=3D ${BUILD_DEPENDS}
=20
MAN3=3D Net::SSH::Perl::Constants.3 \
Net::SSH::Perl::Util.3 \
@@ -74,4 +76,4 @@
Net::SSH::Perl::Cipher::DES3.3 \
Net::SSH::Perl::Channel.3
=20
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--wac7ysb48OaltWcw--
--Fba/0zbH8Xs+Fj9o
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iQGVAwUBQSjkVlaRERsSueCzAQLDagv/fXctOJ7k0E6ZjNoy3YtySJr4IPes4k3S
j/VFdUyP2FOO1hJgsuem++6ORfn2rMTjiHZpPFd1zLXUZZeQ7uAavNSbls3rQ/v9
TkOWhjfouKmC9Jk2csbCl9z9aA6G7D6KBEM9bCYEuI34NhjfHP6ADTkEZ6foln+h
dY2JLsK8NUddV7Z9kWFgB3TcuKadaQk1sIHVw2TSGiJ1lzuCFJAFykfaNNtUNUoG
4QuExTEiirTtu3/eQf7lH7SCv+E5TGv9yS8Q20eeJB4cT+MOfBx5bzbGZqcZKjF7
TNOhHl+Ei2EhIEqW7JYNvjE7fZIOo1XsQB+rzWBDQDeYNB5MOTm/1+mg0U/112gb
z7Fbx4JdoKI85X9vOX4pISxJ9g5/735qGmf5wSaigkGrAtD2ctIgde25CtinGTL7
vy6NE9Pzg9HDnI/5RQ9zRxWH6v+AFjzfLZ8iEQjp7IB/XS3jZ3j6VuKYhgdZ2DxU
m4Ie2rpzsgZrClAT6P37fdkjJxHNhCTU
=Fr1V
-----END PGP SIGNATURE-----
--Fba/0zbH8Xs+Fj9o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040822182215.GA20724>