Date: Tue, 20 Mar 2018 12:41:27 -0400 From: Ed Maste <emaste@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331226 - in head/sys: amd64/linux amd64/linux32 i386/linux Message-ID: <CAPyFy2AOnfaTJEzffrfDvSxRphA_EYMe=uXkPmGP17G8YMSagA@mail.gmail.com> In-Reply-To: <20180320183744.S950@besplex.bde.org> References: <201803192126.w2JLQW0N039356@repo.freebsd.org> <20180320183744.S950@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 March 2018 at 04:19, Bruce Evans <brde@optusnet.com.au> wrote: > > It is preferable to have a well-chosen (short...) prefix. The linux > emulator mostly uses l_ for internal names. That is a bit too short > for external names. l_ is too short. The only reasonable alternative is probably lnx_ but saving two characters seems does not seem worth it. > 'elf_' is an example of a well-chosen prefix. Not for Linux-specific things. There are currently three copies of these functions, and I'm going to move them so they can be shared by the Linuxulator on all appropriate archs. > I don't like the style of putting the verb last in names, but it goes well > with putting prefixes first. Here the verb placement style is random -- > the verb is last in ...handler_set and ...elf_fixup, but not last in > ...copyout_strings. These names are consistent with the sysentvec names. sv_copyout_strings = linux_strings_copyout seems confusing for no real benefit. > Names without any prefix are likely to have had the verb first, and now > in the middle. It should probably not be plural either. This could be linux_trap_translate instead.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2AOnfaTJEzffrfDvSxRphA_EYMe=uXkPmGP17G8YMSagA>