Date: Wed, 2 Feb 2005 18:48:56 GMT From: fergus cameron <fergus@cameron-consulting.ie> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048) Message-ID: <200502021848.j12Imun5060952@www.freebsd.org> Resent-Message-ID: <200502021850.j12IoMI3008845@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 77031
>Category: misc
>Synopsis: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Feb 02 18:50:22 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: fergus cameron
>Release: FreeBSD rabbit.cobbled.net 5.3-STABLE FreeBSD 5.3-STABLE #3: Tue Dec 7 20:41:00 GMT 2004 root@rabbit.cobbled.net:/usr/cabinet/software/binary/FreeBSD/build/usr/cabinet/software/source/FreeBSD/RELENG_5/sys/RABBIT i386
>Organization:
cameron-consulting.ie
>Environment:
FreeBSD rabbit.cobbled.net 5.3-STABLE FreeBSD 5.3-STABLE #3: Tue Dec 7 20:41:00 GMT 2004 root@rabbit.cobbled.net:/usr/cabinet/software/binary/FreeBSD/build/usr/cabinet/software/source/FreeBSD/RELENG_5/sys/RABBIT i386
>Description:
comm(1) utility will incorrectly handle lines longer than 2048 characters.
>How-To-Repeat:
create test files with lines of greater length than 2048 and run the utility against them. note that due to the way lines are processed it 'appears' to work, however comparisons and line ouputs are incorrect.
>Fix:
patch at
ftp://ftp.cameron-consulting.ie/comm.c-diff
anon access via "ftp@cameron-consulting.ie" user name
this is a large patch (for the size of the problem) and equates to almost a complete re-write of the utility. the case insensitive option still needs re-implemented.
let me know of issues with the code and or style as it has changed greatly to suit personal (in-experienced) coding style.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502021848.j12Imun5060952>