Date: Thu, 10 Mar 2005 16:03:26 -0500 From: Jung-uk Kim <jkim@niksun.com> To: Bruno Ducrot <ducrot@poupinou.org> Cc: freebsd-acpi@freebsd.org Subject: Re: [cpufreq] powernow drivers Message-ID: <200503101603.26659.jkim@niksun.com> In-Reply-To: <4230AF39.4090100@root.org> References: <20050310171025.GB2298@poupinou.org> <4230AF39.4090100@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 10 March 2005 03:34 pm, Nate Lawson wrote: > Bruno Ducrot wrote: > > The powernow stuff is nearly complete but need testings and more > > cleanup, especially the 2 drivers shoud be merged. > > I'm providing them right now at > > http://www.poupinou.org/cpufreq/bsd/powernow.tar.gz > > before the merge because I maybe offline for one or two weeks in > > a few days. > > > > The powernow k6 is not finished, but mainly because I dont have > > the hardware. It would be fine though that I know for sure that > > someone test it before I make it public, so if you have a cyrix > > K6/II or III with powernow! capability and you want to test > > please write me. > > Excellent, your work looks really nice. Just a few comments: > > Please remove my name from the copyright. You did all the work and > I just provided suggestions. You can remove mine too. This driver doesn't look like acpi_cnq at all. ;-) > Both drivers should just add a child called "powernow" instead of > k*_powernow. You can't have k7 and k8 powernow on the same system, > right? They can announce what hardware they are via > device_set_desc() which it appears you're already doing. Also, > DRIVER_MODULE for them should not have "pn8" as the first arg. > > You can remove the check for a freq >= 0xffff. I committed this to > acpi_perf already. > > Have you tested the ACPI attachment for this? Does it work ok? > I'm just curious because I don't have hw to test acpi-assisted > probing. I have and it works. > It looks like these can be merged pretty easily. Once you've done > that, I'd like to import this driver. > > Thanks very much, Thank you, both of you, Jung-uk Kim > -- > Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503101603.26659.jkim>