Date: Wed, 27 Oct 2004 02:17:03 GMT From: Darrin Smith <sdar@salseast.org> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/73183: nfs_diskless.c lacking include of #if options Message-ID: <200410270217.i9R2H3BN025105@www.freebsd.org> Resent-Message-ID: <200410270220.i9R2KKci046355@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 73183
>Category: misc
>Synopsis: nfs_diskless.c lacking include of #if options
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 27 02:20:20 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Darrin Smith
>Release: 5.3-BETA6
>Organization:
Salisbury East High School
>Environment:
FreeBSD big-brother.sehs.sec 5.3-BETA6 FreeBSD 5.3-BETA6 #3: Wed Oct 6 15:53:24 CST 2004 sdar@big-brother.sehs.sec:/src/obj/src/src5/sys/SEHS i386
>Description:
sys/nfsclient/nfs_diskless.c contains and #if !defined(BOOTP_NFSROOT) near the bottom of the file which is ALWAYS included since "opt_bootp.h" is not included in the file.
>How-To-Repeat:
insert an #error inside #ifdef, define BOOTP_NFSROOT in kernel config, compile and error will trigger
>Fix:
Apply patch:
Index: nfs_diskless.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsclient/nfs_diskless.c,v
retrieving revision 1.8
diff -u -r1.8 nfs_diskless.c
--- nfs_diskless.c 28 Jul 2004 21:54:57 -0000 1.8
+++ nfs_diskless.c 27 Oct 2004 01:33:25 -0000
@@ -35,6 +35,8 @@
#include <sys/cdefs.h>
__FBSDID("$FreeBSD: src/sys/nfsclient/nfs_diskless.c,v 1.8 2004/07/28 21:54:57 phk Exp $");
+#include "opt_bootp.h"
+
#include <sys/param.h>
#include <sys/systm.h>
#include <sys/kernel.h>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410270217.i9R2H3BN025105>