Date: Wed, 23 May 2007 19:23:14 +0100 From: Rui Paulo <rpaulo@fnop.net> To: Andrew Gallatin <gallatin@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c Message-ID: <86bqgbs8kt.wl%rpaulo@fnop.net> In-Reply-To: <200705231531.l4NFV12H058289@repoman.freebsd.org> References: <200705231531.l4NFV12H058289@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Wed, 23 May 2007 15:31:01 +0000 (UTC),
Andrew Gallatin wrote:
>
> gallatin 2007-05-23 15:31:01 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/dev/pci pci_pci.c
> Log:
> Fix a typo in pcib_alloc_msi{x} which resulted in the
> device's, not the bridge's, softc to be used to check the
> PCIB_DISABLE_MSI flag. This resulted in randomly allowing
> or denying MSI interrupts based on whatever value the driver
> happened to store at sizeof(device_t) bytes into its softc.
>
> I noticed this when I stopped getting MSI interrupts
> after slighly re-arranging mxge's softc yesterday.
Wow, I'll have to try this out on msk(4)..
--
Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bqgbs8kt.wl%rpaulo>