Date: Tue, 30 May 2000 14:55:26 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: itojun@iijlab.net (Jun-ichiro itojun Hagino) Cc: freebsd-net@FreeBSD.ORG Subject: Re: BPF fix to if_loop.c Message-ID: <200005302155.OAA00803@bubba.whistle.com> In-Reply-To: <7130.959686610@lychee.itojun.org> from Jun-ichiro itojun Hagino at "May 30, 2000 08:36:50 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Jun-ichiro itojun Hagino writes:
> > The following one-liner avoids junk (non-matching DLT_xx encapsulation)
> > to be injected to bpf, non-loopback ifp is passed to if_simloop.
> >- if (ifp->if_bpf) {
> >+ if (ifp->if_bpf && ifp->if_flags & IFF_LOOPBACK) {
>
> sorry this was incorrect. however, I think there should be check
> if ifp really wants DLT_NULL encapsulation or not.
Hmm.. maybe a better fix is to remove this BPF section altogether.. ?
It's only going to result in showing the same packet twice, right?
-Archie
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200005302155.OAA00803>