Date: Thu, 5 Jun 1997 21:40:03 -0700 (PDT) From: asami@cs.berkeley.edu (Satoshi Asami) To: freebsd-ports Subject: Re: ports/3757 Message-ID: <199706060440.VAA26360@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/3757; it has been noted by GNATS. From: asami@cs.berkeley.edu (Satoshi Asami) To: rssh@cki.ipri.kiev.ua Cc: freebsd-gnats-submit@freebsd.org Subject: Re: ports/3757 Date: Thu, 5 Jun 1997 19:45:31 -0700 (PDT) * New put, becouse many is changed, new files is added --- so, * new put in this case better then diff. Thanks...by the way, the "please submit diff" comment applies when the original is committed. If you are changing your own port that's still in incoming/, a new tarball is fine. I took a look at the port, it looks much better now. I made a few changes: === diff -ru simpack/Makefile simpack.new/Makefile --- simpack/Makefile Thu Jun 5 03:23:30 1997 +++ simpack.new/Makefile Thu Jun 5 19:23:20 1997 @@ -7,13 +7,12 @@ # DISTNAME= simpack-3.0 -DISTFILES= SimPack3.tar.Z -CATEGORIES= match +CATEGORIES= math MASTER_SITES= ftp://ftp.cis.ufl.edu/pub/simdigest/tools/ +DISTFILES= SimPack3.tar.Z MAINTAINER= rssh@cki.ipri.kiev.ua -EXTRACT_SUFX= .tar.Z WRKSRC= ${WRKDIR}/simpack post-build: create-libs create-scripts @@ -21,35 +20,34 @@ do-install: do-install-bin do-install-include do-install-lib do-install-doc post-install: - @/sbin/ldconfig ${PREFIX}/lib - + @${LDCONFIG} ${PREFIX}/lib do-install-bin: - @for i in `cat ${FILESDIR}/FILES-BIN` ; do \ + @for i in `${CAT} ${FILESDIR}/FILES-BIN` ; do \ ${INSTALL_PROGRAM} ${WRKSRC}/$$i ${PREFIX}/bin; \ done @${INSTALL_SCRIPT} ${WRKDIR}/temp/sdsmt.alias ${PREFIX}/bin/sdsmt @${INSTALL_SCRIPT} ${WRKDIR}/temp/deq.alias ${PREFIX}/bin/deq do-install-include: - @mkdir -p ${PREFIX}/include/Sim++ - @for i in `cat ${FILESDIR}/FILES-INCLUDE-SIMPP` ; do \ + @${MKDIR} ${PREFIX}/include/Sim++ + @for i in `${CAT} ${FILESDIR}/FILES-INCLUDE-SIMPP` ; do \ ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/include/Sim++ ; \ done - @mkdir -p ${PREFIX}/include/queuing - @for i in `cat ${FILESDIR}/FILES-INCLUDE-QUEUING` ; do \ + @${MKDIR} ${PREFIX}/include/queuing + @for i in `${CAT} ${FILESDIR}/FILES-INCLUDE-QUEUING` ; do \ ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/include/queuing/ ; \ done do-install-lib: - @mkdir -p ${PREFIX}/lib/Sim++/olb - @for i in `cat ${FILESDIR}/FILES-OLB` ; do \ + @${MKDIR} ${PREFIX}/lib/Sim++/olb + @for i in `${CAT} ${FILESDIR}/FILES-OLB` ; do \ ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/lib/Sim++/olb/ ; \ done - @for i in `cat ${FILESDIR}/DIRS-LIB` ; do \ - mkdir -p ${PREFIX}/lib/SimPack/$$i ; \ + @for i in `${CAT} ${FILESDIR}/DIRS-LIB` ; do \ + ${MKDIR} ${PREFIX}/lib/SimPack/$$i ; \ done - @for i in `cat ${FILESDIR}/FILES-LIB` ; do \ + @for i in `${CAT} ${FILESDIR}/FILES-LIB` ; do \ ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/lib/SimPack/$$i ; \ done @${INSTALL_DATA} ${WRKDIR}/temp/libsim++.a ${PREFIX}/lib/libsim++.a @@ -58,75 +56,68 @@ @${INSTALL_DATA} ${WRKDIR}/temp/libqueuing.a ${PREFIX}/lib/libqueuing.a; @${INSTALL_DATA} ${WRKDIR}/temp/libqueuing.so.1.0 \ ${PREFIX}/lib/libqueuing.so.1.0 - - do-install-doc: - @for i in `cat ${FILESDIR}/DIRS-SHARE` ; do \ - mkdir -p ${PREFIX}/share/SimPack/$$i; \ + @for i in `${CAT} ${FILESDIR}/DIRS-SHARE` ; do \ + ${MKDIR} ${PREFIX}/share/SimPack/$$i; \ done - @for i in `cat ${FILESDIR}/FILES-SHARE` ; do \ + @for i in `${CAT} ${FILESDIR}/FILES-SHARE` ; do \ ${INSTALL_DATA} ${WRKSRC}/$$i ${PREFIX}/share/SimPack/$$i ; \ done create-libs: create-lib-sim++ create-lib-queuing -create-lib-sim++: ${WRKDIR}/temp/.created - @echo libsim++.a - @mkdir -p ${WRKDIR}/temp +create-lib-sim++: + @${ECHO} libsim++.a + @${MKDIR} ${WRKDIR}/temp @(cd ${WRKDIR}/temp; \ - for i in `cat ${FILESDIR}/FILES-SRC-SIMPP` ; do \ + for i in `${CAT} ${FILESDIR}/FILES-SRC-SIMPP` ; do \ gcc -I${WRKSRC}/func/event/include -c -O \ ${WRKSRC}/func/event/src/$$i ; \ done; \ ${AR} cq libsim++.a `lorder *.o | tsort -q `; \ - rm *.o ) - @echo libsim++.so.1.0 + ${RM} *.o ) + @${ECHO} libsim++.so.1.0 @(cd ${WRKDIR}/temp; \ - for i in `cat ${FILESDIR}/FILES-SRC-SIMPP` ; do \ + for i in `${CAT} ${FILESDIR}/FILES-SRC-SIMPP` ; do \ gcc -fpic -DPIC -I${WRKSRC}/func/event/include -c -O \ -o `basename $$i cpp`.so \ ${WRKSRC}/func/event/src/$$i ; \ done; \ ${LD} -Bshareable -x -o libsim++.so.1.0 \ `lorder *.so | tsort -q ` ; \ - rm *.so ) + ${RM} *.so ) -create-lib-queuing: ${WRKDIR}/temp/.created - @echo libqueuing.a +create-lib-queuing: + @${ECHO} libqueuing.a @(cd ${WRKDIR}/temp; \ gcc -I${WRKSRC}/func/queuing -c -O \ ${WRKSRC}/func/queuing/queuing.c; \ ${AR} cq libqueuing.a `lorder *.o | tsort -q `; \ - rm *.o ) - @echo libqueuing.so.1.0 + ${RM} *.o ) + @${ECHO} libqueuing.so.1.0 @(cd ${WRKDIR}/temp; \ gcc -fpic -DPIC -I${WRKSRC}/func/queuing -c -O \ -o queuing.so \ ${WRKSRC}/func/queuing/queuing.c ; \ ${LD} -Bshareable -x -o libqueuing.so.1.0 \ `lorder *.so | tsort -q ` ; \ - rm *.so ) + ${RM} *.so ) create-scripts: create-sdsmt-alias create-deq-alias -create-sdsmt-alias: ${WRKDIR}/temp/.created - @echo SDSMTLIB=${PREFIX}/lib/SimPack/func/slice/sdsmt \ +create-sdsmt-alias: + @${ECHO} SDSMTLIB=${PREFIX}/lib/SimPack/func/slice/sdsmt \ > ${WRKDIR}/temp/sdsmt.alias - @echo export SDSMTLIB >> ${WRKDIR}/temp/sdsmt.alias - @echo wish4.1 ${PREFIX}/lib/SimPack/func/slice/sdsmt/sdsmt \ + @${ECHO} export SDSMTLIB >> ${WRKDIR}/temp/sdsmt.alias + @${ECHO} wish4.1 ${PREFIX}/lib/SimPack/func/slice/sdsmt/sdsmt \ >> ${WRKDIR}/temp/sdsmt.alias -create-deq-alias: ${WRKDIR}/temp/.created - @echo PATCH=${PREFIX}/lib/SimPack/constraint/differential:$$PATCH \ +create-deq-alias: + @${ECHO} PATCH=${PREFIX}/lib/SimPack/constraint/differential:$$PATCH \ > ${WRKDIR}/temp/deq.alias - @echo export PATCH >> ${WRKDIR}/temp/deq.alias - @echo ${PREFIX}/lib/SimPack/constraint/differential/deq $$* \ + @${ECHO} export PATCH >> ${WRKDIR}/temp/deq.alias + @${ECHO} ${PREFIX}/lib/SimPack/constraint/differential/deq $$* \ >> ${WRKDIR}/temp/deq.alias - -${WRKDIR}/temp/.created: - @mkdir -p ${WRKDIR}/temp - @touch ${WRKDIR}/temp/.created - .include <bsd.port.mk> diff -ru simpack/pkg/PLIST simpack.new/pkg/PLIST --- simpack/pkg/PLIST Thu Jun 5 03:15:56 1997 +++ simpack.new/pkg/PLIST Thu Jun 5 19:23:50 1997 @@ -1,4 +1,3 @@ -@name simpack-3.0 bin/fsa bin/markov bin/petri === Most of the changes are cosmetic, i.e., remonving extra spaces at the end of line, etc. Actually now that I look at the diffs, I may have screwed up your neatly aligned \'s. Sorry if that's the case. By the way, before I commit this, I have one more request: this port asks several questions. They are either (1) have you read the license, and do you agree to abide with it?, or (2) do you want to build this part of the package? For (1), I would like you to make it print the license regardless. You can print it from pkg/INSTALL (as a post-installation script -- see pkg_add(1)) and also call it from post-install. Make sure that you don't ask the question if BATCH or PACKAGE_BUILDING is defined (I don't care which, I set them both) so it won't interrupt batch package builds. You can alternatively do it from the pkg/REQ script, but that is less convenient because none of the files have been extracted at that point. (Instead of "cat <somefile>", you need to embed the license itself in the script.) If you can do it that way, it is fine too (and is probably more in line with the original author's intent). As for (2), I don't think we should be asking users those kind of questions. Can you patch the source so "y" is assumed for all of them? Thanks, Satoshi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199706060440.VAA26360>