Date: Mon, 21 Oct 2019 10:10:12 +0200 From: Niclas Zeising <zeising+freebsd@daemonic.se> To: Thomas Mueller <mueller6722@twc.com>, freebsd-current@freebsd.org Subject: Re: DRM-current-kmod is still a problem at r353339 Message-ID: <b18a9fa3-76cb-949e-348b-fcd2a91ac247@daemonic.se> In-Reply-To: <befd67a87f99d16aa8559f5be52eaad9@neelc.org> References: <CAGudoHG_aAcqOfSi0GCW5-yw=6RcEXB0dz72mkgdJoz0guJMHA@mail.gmail.com> <7ca3b30a-81f6-f79d-1486-7fd29765646f@acm.org> <CAGudoHE755ig7KGuzq8uNY01K2Jcf-MKBjCp8kbpJAoiHdbQMA@mail.gmail.com> <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <f2e7c4b4c236ee694f277d78479cb6ee@neelc.org> <CAGudoHGwmp=vNwOy2W22rjx_mQj1nkbdYzuLfayM7O0vn4keeA@mail.gmail.com> <bb951f83-6a50-48ce-8efa-b8fa92a9840e@yggdrasil.evilham.com> <CAGudoHGoikyZudFSxYjypF8EL24BPxBTPQjAnCKTe%2Bvg3DJiWQ@mail.gmail.com> <bb4f31fcb7f06059f1d9fe391b119661@neelc.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> <f0f64057-2d8a-9ec2-9d01-91e2265f8a91@anduin.net> <72d67f0a-aeef-1c06-2b12-9351a1f52060@anduin.net> <689d53378dcca22adb29aa23f03e8e1b@neelc.org> <25593555-6452-0933-d0fe-0459425cde55@delphij.net> <7cb6ecd6-2dcd-92e4-75a3-5e5d34377ed6@yuripv.net> <befd67a87f99d16aa8559f5be52eaad9@neelc.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-10-21 09:01, Thomas Mueller wrote: > from Neel Chauhan: > >> For me, the following code is still necessary for me (HP Spectre x360 >> 2018), which is the remaining parts of the patches not committed if you >> are using a recent kernel. I don't know about you all ThinkPad users, it >> should still apply as it's Intel in general not just HP or Lenovo. >> Without these patches, I get a kernel panic. > >> Keep in mind that the patch may render as spaces, but it should be tabs. > > What happens if the patch is applied with spaces as opposed to tabs? > > I believe, in C, there is no difference as far as compiling is concerned. > > Or is it just a standard for formatting? > If the whitespace isn't correct, the patch won't apply cleanly. It has no effect on compiling the code though. Regards -- Niclas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b18a9fa3-76cb-949e-348b-fcd2a91ac247>