Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Apr 2019 15:28:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 236944] security/strongswan: startup script improvements
Message-ID:  <bug-236944-7788-23TENd8x4u@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-236944-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-236944-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236944

--- Comment #6 from Jose Luis Duran <jlduran@gmail.com> ---
(In reply to Sam Chen from comment #5)

Thank you for taking the time to review the patch:

1) I tried to keep it similar to ipsec.in, currently the failing exit code =
for
reload is 7:

https://github.com/strongswan/strongswan/blob/5c38a5ea832accec3a8d3942d878a=
c5be5bb2a4b/src/ipsec/_ipsec.in#L171

2) The idea is not to use a hard-coded sleep, else I would prefer to use 2
seconds, which is what ipsec.in is currently using (see comment #0). The id=
ea
is that if $charon_pidfile still exists after stopping the service, wait
another second.

What I would like to do is to rely more on rc.subr to clean up the code a b=
it
more. By using $pidfile and perhaps $procname.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236944-7788-23TENd8x4u>