Date: Sun, 10 Feb 2008 15:41:27 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Robert Watson" <rwatson@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys lockmgr.h Message-ID: <3bbf2fe10802100641k4ebbf44fgc32978175678cb22@mail.gmail.com> In-Reply-To: <20080210143313.W90254@fledge.watson.org> References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> <20080210113949.GN57756@deviant.kiev.zoral.com.ua> <20080210120359.A97821@fledge.watson.org> <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com> <20080210143313.W90254@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2008/2/10, Robert Watson <rwatson@freebsd.org>: > > On Sun, 10 Feb 2008, Attilio Rao wrote: > > >> > I think this shall be MFCed to RELENG_7 and RELENG_7_0. > >> > >> ... once it no longer breaks the tinderbox? > >> > >> BTW, at this point 7.0 is basically closed to any further changes. Anyone > >> planning on getting things in to 7.x needs to be thinking about either > >> errata notices (for really critical things) and 7.1. > > > > Buh! I'm very sorry for this. Really, this needed to be better croaked. It > > needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a > > pre-requirement in lockmgr usage). This is going to be a little bit of work. > > > > For the moment I will revert this change, doing a better stub later, once > > other details about lockmgr are refined. > > > Or temporarily nested include lock.h from lockmgr.h. I'm pretty sure that all > consumers of struct lock pretty much include _lock.h, so if there's a > widespread dependency you could also move whatever the definitions are to > _lock.h. As long as this is also temporary code, I would prefer to move lock.h into lockmgr.h as solution. I don't want to touch _lock.h as traditionally (about all the other locking primitives too) this only includes structures definition and related macros (which has nothing to do with this specific problem). Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10802100641k4ebbf44fgc32978175678cb22>