Date: Mon, 15 Feb 2016 18:06:06 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206956] x11-wm/herbstluftwm: update to 0.7.0 Message-ID: <bug-206956-13-qMVLjvQeRz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-206956-13@https.bugs.freebsd.org/bugzilla/> References: <bug-206956-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206956 --- Comment #6 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- I've just tested the patch on 9.3-i386 again and it worked now. I only have one comment this time: setting both VERBOSE and COLOR in MAKE_A= RGS is redundant. If you set VERBOSE=3D"", then that colorecho function in colo= rs.mk will not be defined and the COLOR_* variables won't be used at all, so doing COLOR=3D0 is unnecessary. On the other hand, if you do COLOR=3D0 without VERBOSE=3D"", you get non-verbose build output without colors, which also s= olves the tput warnings issue. I think you should decide whether you prefer verbo= se or non-verbose build output and set one variable or the other based on that. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206956-13-qMVLjvQeRz>