Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jan 2002 16:41:04 -0500
From:      Garance A Drosihn <drosih@rpi.edu>
To:        "Tim J. Robbins" <tim@robbins.dropbear.id.au>, freebsd-standards@FreeBSD.ORG
Subject:   Re: fold -b and -s options patch
Message-ID:  <p0510121cb87e117b9add@[128.113.24.47]>
In-Reply-To: <20020130201615.A9151@descent.robbins.dropbear.id.au>
References:  <20020130201615.A9151@descent.robbins.dropbear.id.au>

next in thread | previous in thread | raw e-mail | index | archive | help
At 8:16 PM +1100 1/30/02, Tim J. Robbins wrote:
>This patch adds the -b and -s options to fold. It's mostly taken from
>NetBSD but I've hopefully kept it compilable by K&R compilers.

If you're picking up code from NetBSD or OpenBSD, then you certainly
do not need to add __P()'s to it.  FreeBSD developers have repeatedly
decided that we should also move to ANSI instead of K&R, even though
there are a few holdouts who seem to believe that no such agreement
has been reached.     One justification for *keeping* __P()'s is to
be compatible with source from the other BSD's, and in this case even
that argument would say that __P()'s should not be added.

[this is just a minor comment on your changes though, obviously it's
good that you're trying to chip away at the list of programs we want
to update to the latest standards!]

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510121cb87e117b9add>