Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Jun 2001 15:48:10 -0400
From:      Garance A Drosihn <drosih@rpi.edu>
To:        freebsd-print@bostonradio.org, freebsd-audit@FreeBSD.ORG
Subject:   Re: Large Cleanup update for lpr & friends
Message-ID:  <p05100e14b74585c3ff2f@[128.113.24.47]>
In-Reply-To: <p05100e15b7405db984d7@[128.113.24.47]>
References:  <p05100e15b7405db984d7@[128.113.24.47]>

next in thread | previous in thread | raw e-mail | index | archive | help
At 6:08 PM -0400 6/3/01, Garance A Drosihn wrote:
>The patch is about 2300 lines, so I think I'll post a
>url instead of including the whole patch here.  The
>result is at:
>
>ftp://freefour.acs.rpi.edu/pub/bsdlpr/lpr-spruce.diff

New version is at:
ftp://freefour.acs.rpi.edu/pub/bsdlpr/lpr-spruce2.diff

This DOES result in object-code changes for lpd.o on alpha
(but not on i386).  The problem is that the current code has
a declaration of:

static int   sendfile __P((struct printer *pp, int type,
                  char *file, int format));

but a routine definition of:

static int
sendfile(pp, type, file, format)
	struct printer *pp;
	int type;
	char *file;
	char format;		/* <- note */
{ ... }

In ansi-fying this, I have to use 'int' or 'char' for both
versions of 'format', and either choice will result in a
change to the object code under Alpha.

I think this is pretty much ready to go.  Even if it could
be more extensive, it's about as much as I want to tackle
in a single pass.

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05100e14b74585c3ff2f>