Date: Fri, 11 Dec 2009 17:02:29 +0200 From: Andriy Gapon <avg@icyb.net.ua> To: Grzegorz Bernacki <gjb@semihalf.com> Cc: Alexander Motin <mav@freebsd.org>, freebsd-current@freebsd.org Subject: Re: Possible bug in ata-disk.c Message-ID: <4B225F05.20004@icyb.net.ua> In-Reply-To: <4B2252BE.8080806@semihalf.com> References: <4B2252BE.8080806@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 11/12/2009 16:10 Grzegorz Bernacki said the following: > Hi, > > I've looked over ATA code and I've noticed that setting > DISKFLAG_CANDELETE big in disk->d_flags clears DISKFLAGS_CANFLUSHCAHCE > bit if it was set. Below is the patch. > > --- a/sys/dev/ata/ata-disk.c > +++ b/sys/dev/ata/ata-disk.c > @@ -133,11 +133,11 @@ ad_attach(device_t dev) > adp->disk->d_unit = device_get_unit(dev); > if (atadev->param.support.command2 & ATA_SUPPORT_FLUSHCACHE) > adp->disk->d_flags = DISKFLAG_CANFLUSHCACHE; > if ((atadev->param.support.command2 & ATA_SUPPORT_CFA) || > atadev->param.config == ATA_PROTO_CFA) > - adp->disk->d_flags |= DISKFLAG_CANDELETE; > + adp->disk->d_flags = DISKFLAG_CANDELETE; > snprintf(adp->disk->d_ident, sizeof(adp->disk->d_ident), "ad:%s", > atadev->param.serial); > disk_create(adp->disk, DISK_VERSION); > device_add_child(dev, "subdisk", device_get_unit(dev)); > ad_firmware_geom_adjust(dev, adp->disk); It seems that you are correct. The only confusing thing is that you supplied a reverse diff :) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B225F05.20004>