Date: Mon, 06 Aug 2018 05:54:38 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230390] audio/xmms-faad: Update to 2.8.8 Message-ID: <bug-230390-7788-RP2awWm8QL@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230390-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-230390-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230390 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|New |Closed Assignee|ports-bugs@FreeBSD.org |tobik@freebsd.org --- Comment #5 from Tobias Kortkamp <tobik@freebsd.org> --- Committed with some changes. Thanks! - xmms-faad is an XMMS plugin and should not install libfaad.3, which is just API documentation for audio/faad. audio/faad should be changed to install it (audio/{faad,xmms-faad} share a distfile). Open a new PR for it! - Do not introduce new non-standard variables (i.e. WRKSRCDIR), when standard variables will do. Here BUILD_WRKSRC could have been set for just the build phase. (Since libfaad.3 is not being installed now it's not necessary anymore though.) - USE_LDCONFIG is not necessary here (portlint is sometimes wrong). The port installs a plugin that is directly dlopened by XMMS. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230390-7788-RP2awWm8QL>