Date: Wed, 20 Nov 2013 09:27:12 +0100 From: "Ronald Klop" <ronald-freebsd8@klop.yi.org> To: "George V. Neville-Neil" <gnn@freebsd.org>, "Luigi Rizzo" <rizzo@iet.unipi.it> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258328 - head/sys/net Message-ID: <op.w6t9rmoi8527sy@ronaldradial> In-Reply-To: <20131119210821.GA13961@onelab2.iet.unipi.it> References: <201311182258.rAIMwEFd048783@svn.freebsd.org> <20131119210821.GA13961@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Nov 2013 22:08:21 +0100, Luigi Rizzo <rizzo@iet.unipi.it> wrote: > On Mon, Nov 18, 2013 at 10:58:14PM +0000, George V. Neville-Neil wrote: >> Author: gnn >> Date: Mon Nov 18 22:58:14 2013 >> New Revision: 258328 >> URL: http://svnweb.freebsd.org/changeset/base/258328 >> >> Log: >> Allow ethernet drivers to pass in packets connected via the nextpkt >> pointer. >> Handling packets in this way allows drivers to amortize work during >> packet reception. > > yes. > > This is only a first step and eventually we should pass the entire > batch to the netisr handler to further reduce overhead. > > Some of the followup emails suggested to change the argument from > struct mbuf * to something else. > I do think we should change it, but what we need is a struct with > head and tail pointers _and_ a counter, because sometimes the code > downstream may have to append the mbuf/batch to a queue, > and these extra fields would save iterating through the chain. > > Related to this: at some point we should also address batching > in the transmit path, and for that we will eventually need to > introduce a 'more packets to come' flag to the API/mbuf so that > intermediate functions in the path will build batches before passing > them down. > > cheers > luigi The Apache webserver works like this also. It has a 'bucket'-list which chains all data of a request and can also contain flush-commands in between. Probably nice to look what they do and in what ways. Ronald.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.w6t9rmoi8527sy>