Date: Thu, 21 May 1998 10:12:50 -0700 From: "Jordan K. Hubbard" <jkh@time.cdrom.com> To: "Justin T. Gibbs" <gibbs@plutotech.com> Cc: "Jordan K. Hubbard" <jkh@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h Message-ID: <27038.895770770@time.cdrom.com> In-Reply-To: Your message of "Thu, 21 May 1998 10:37:32 MDT." <199805211641.KAA15418@pluto.plutotech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> No, no, no. Create an osreldate.h file instead. Please? Using __FreeBSD__ > doesn't work because it's tied to the compiler, not the source. 1. The osreldate.h file just isn't created in time and if we want our SNAP builds to work for now, this change has to happen. If we want to work out how to get the osreldate.h file bootstrapped into place at a later time then that's fine with me, but there's no use holding up the show until then. 2. Absolutely *nothing* else in the system that I've been able to find uses __FreeBSD_version directly in the way that this driver did. If this is really a step forward then I'd suggest that a whole lot more needs changing if self-consistency is also your goal (and I think it should be, especially where this kind of stuff is concerned, since other driver writers will imitate it). - Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?27038.895770770>