Date: Tue, 12 Oct 2010 19:22:03 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r213742 - head/sys/dev/bge Message-ID: <201010121922.o9CJM3Ta059292@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: yongari Date: Tue Oct 12 19:22:03 2010 New Revision: 213742 URL: http://svn.freebsd.org/changeset/base/213742 Log: Fix a regression introduced in r213495. r213495 disabled mini receive producer ring only for BCM5700. It was believed that BCM5700 with external SSRAM is the only controller that supports mini ring but it seems all BCM570[0-4] requires to disable mini receive producer ring. Otherwise, it caused unexpected RX DMA error or watchdog timeouts. Reported by: marius, Steve Kargl <sgk <> troutmask dot apl dot washington dot edu> Tested by: marius, Steve Kargl <sgk <> troutmask dot apl dot washington dot edu> Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Tue Oct 12 19:07:36 2010 (r213741) +++ head/sys/dev/bge/if_bge.c Tue Oct 12 19:22:03 2010 (r213742) @@ -1655,7 +1655,7 @@ bge_blockinit(struct bge_softc *sc) } /* Disable the mini receive producer ring RCB. */ - if (sc->bge_asicrev == BGE_ASICREV_BCM5700) { + if (BGE_IS_5700_FAMILY(sc)) { rcb = &sc->bge_ldata.bge_info.bge_mini_rx_rcb; rcb->bge_maxlen_flags = BGE_RCB_MAXLEN_FLAGS(0, BGE_RCB_FLAG_RING_DISABLED);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010121922.o9CJM3Ta059292>