Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Sep 2015 08:16:14 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Konstantin Belousov <kib@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r287366 - head/sys/kern
Message-ID:  <20150902061614.GB61752@ivaldir.etoilebsd.net>
In-Reply-To: <201509011405.t81E5U0g025928@repo.freebsd.org>
References:  <201509011405.t81E5U0g025928@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--eAbsdosE1cNLO4uF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 01, 2015 at 02:05:30PM +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Tue Sep  1 14:05:29 2015
> New Revision: 287366
> URL: https://svnweb.freebsd.org/changeset/base/287366
>=20
> Log:
>   Exit notification for EVFILT_PROC removes knote from the knlist.  In
>   particular, this invalidates the knote kn_link linkage, making the
>   SLIST_FOREACH() loop accessing undefined values (e.g. trashed by
>   QUEUE_MACRO_DEBUG).  If the knote is freed by other thread when kq
>   lock is released or when influx is cleared, e.g. by knote_scan() for
>   kqueue owning the knote, the iteration step would access freed memory.
>  =20
>   Use SLIST_FOREACH_SAFE() to fix iteration.
>  =20
>   Diagnosed by:	avg
>   Tested by:	avg, lstewart, pawel
>   Sponsored by:	The FreeBSD Foundation
>   MFC after:	2 weeks
>=20
Thank you! that makes my package builders stable again!

Best regards,
Bapt

--eAbsdosE1cNLO4uF
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlXmlC4ACgkQ8kTtMUmk6EwPYgCffTXrongm+5WcyqPlbDnbi0/F
50AAn3UFsEw08TLJKEXcg9hWwuur3Vzp
=FFvj
-----END PGP SIGNATURE-----

--eAbsdosE1cNLO4uF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150902061614.GB61752>