Date: Sat, 14 Feb 2009 19:24:14 +0100 From: Christian Weisgerber <naddy@freebsd.org> To: Lars Eighner <portsuser@larseighner.com> Cc: dnelson@allantgroup.com, freebsd-ports@freebsd.org Subject: Re: Sox in 7.1 broken or corrupt? Message-ID: <20090214182414.GA35805@lorvorc.mips.inka.de> In-Reply-To: <20090214112354.S87224@qroenaqrq.6qbyyneqvnyhc.pbz> References: <20090213172925.R97999@qroenaqrq.6qbyyneqvnyhc.pbz> <gn6ovf$156o$1@lorvorc.mips.inka.de> <20090214112354.S87224@qroenaqrq.6qbyyneqvnyhc.pbz>
next in thread | previous in thread | raw e-mail | index | archive | help
Lars Eighner:
> >> It appears to me the audio/sox port is broken. During configure the
> >> screen breaks up with a bunch of ANSI garbage.
>=20
> Oh, I see. The config script looks for something it calls "distro name" =
in
> /etc/issue . I don't think this is the right way to get this information;
Oh my. This appears to be a desperate attempt to figure out on
which flavor of Linux sox is being built, since Linux distributions
are all different but you can't distinguish them by uname.
We should just disable the whole test. I'll commit this patch if
the maintainer approves.
Index: files/patch-configure
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: files/patch-configure
diff -N files/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ files/patch-configure 14 Feb 2009 18:17:51 -0000
@@ -0,0 +1,11 @@
+--- configure.orig 2009-02-14 19:08:53.000000000 +0100
++++ configure 2009-02-14 19:09:06.000000000 +0100
+@@ -20805,7 +20805,7 @@
+=20
+=20
+=20
+-if test -r /etc/issue; then
++if false && test -r /etc/issue; then
+ { $as_echo "$as_me:$LINENO: checking distro name" >&5
+ $as_echo_n "checking distro name... " >&6; }
+ DISTRO=3D`sed -e "s/=1B.0-90-9;*mJH//g" < /etc/issue|tr "\n" " " | sed =
-e "s/(\\\\?\\\\\\\\.*//" -e "s/ */ /g" -e "s/^ //" -e "s/ $//"`
--=20
Christian "naddy" Weisgerber naddy@mips.inka.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090214182414.GA35805>