Date: Sat, 21 Sep 2013 05:55:28 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r327601 - head/Mk Message-ID: <523D7B20.6020908@FreeBSD.org> In-Reply-To: <20130921104936.GQ73535@ithaqua.etoilebsd.net> References: <201309190805.r8J855cW009011@svn.freebsd.org> <20130921023225.GA19307@FreeBSD.org> <20130921104936.GQ73535@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BADj0kLdlR9EuNP6xbQC8EOTx1gBwkeGj Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 9/21/2013 5:49 AM, Baptiste Daroussin wrote: > On Sat, Sep 21, 2013 at 02:32:25AM +0000, Alexey Dokuchaev wrote: >> On Thu, Sep 19, 2013 at 08:05:05AM +0000, Baptiste Daroussin wrote: >>> New Revision: 327601 >>> URL: http://svnweb.freebsd.org/changeset/ports/327601 >>> >>> Log: >>> Move the target for sanity checking to the end of bsd.port.mk so th= at >>> WARNING and DEV_* can be defined anywhere >> >> From reading the diff, it looks like some part of the portlint(1) was = now >> moved under Mk/. I don't understand why, and what benefits does it br= ing? >> >> Previously we sometimes had to deal with situation when b.p.m. and fri= ends >> code would not match each other, but at least code inside Mk/ was alwa= ys >> consistent. Now it cannot be longer guaranteed. >> >> ./danfe >=20 > That allows to do things portlint is not able to do: warn the users for= > instance, > that allows to be quicker than portlint to wan the dev, more and more Q= A is > coming inside the ports tree directly, stage support opens a way to imp= rove a > lot that will all go. portlint is very good and allow checka that we ar= e not > able to do in port and vice versa. >=20 > regards > Bapt >=20 We also plan to add more commit hooks for things that portlint has checked for. Not everyone runs portlint, and portlint is essentially unmaintained. It is currently severely lagging behind in feature-set checking. By moving to ports, the feature-set checking is always matching the tree. --=20 Regards, Bryan Drewery --BADj0kLdlR9EuNP6xbQC8EOTx1gBwkeGj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSPXsgAAoJEG54KsA8mwz5/8cP/jG3QcjCd4KJYWFHSsKRtuNH X+mhOAz9QabFiQSdKI9lulR9GVjHf2fLXW8VP3THvTjprYi3p79FXhfvdzQ5kWM7 nbw5Ksf7uj6BwA0fMFd2Ndk/oPVFrUDVPjULWqh8lWr4KVwCwRw3A8yhtAAPijiE PQ9igeIB3jKLiB4zOL0jeFsO5K6hWkg3CC/8KBuvkTcYIz9owixYNfAwCHFtscTv ucCc2aMwNhRSBdwsjIb8Q8MVH5wZmlHC8/H2c/aXz8gCsEuiqK2s88ZUvTQmVQjP u3gbxOhyWGJbyBOEXEg0DWOMVR/KUZcqfb9RxrM63XJxzH04qWT6j5UmMl+uhQ8E Lwz41DNjcxqwbA6eKl+lGah+1dscDuYDzhm9LjIju9cB1vAGZFW7DN5035cuCbOS GfZNntfj8es3W9uVF/r8ZmpERBE3y/Z2Z+H0Fl6V9fvh9M5zLbwXdce0XdBHkQPV YRleHoUptuVPXmPnEOS0vFbKKWis47dre+Jrz/zNBoHr25jBiJF4KamZgZtNG5OP gpiqd92MiGQrPHloPcbXlJdTUSsqzsZCO6I3BNdx1Thim1tFesWu8BJIB5G40+H4 kD2wwLGhGvqAQbn1UKrHZ+MR1Jo7wmOP7h9WNVf22p+fQlSX53HUikaXvKR5AL67 QOUCyMoGBHbtyDqHJm1A =BvmX -----END PGP SIGNATURE----- --BADj0kLdlR9EuNP6xbQC8EOTx1gBwkeGj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?523D7B20.6020908>