Date: Fri, 24 Jan 2003 16:21:58 +0100 From: Gary Jennejohn <garyj@jennejohn.org> To: "Ari Suutari" <ari.suutari@syncrontech.com> Cc: "G Hasse" <gh@raditex.se>, joerg@freebsd.org, freebsd-isdn@freebsd.org Subject: Re: Problem with "no bufferspace" - solution Message-ID: <200301241522.h0OFLwj1014253@peedub.jennejohn.org> In-Reply-To: Your message of "Fri, 24 Jan 2003 15:36:01 %2B0200." <000b01c2c3ad$8d0615e0$0235a8c0@raisa>
next in thread | previous in thread | raw e-mail | index | archive | help
"Ari Suutari" writes: > > Gary Jennejohn writes: > > > #if 0 > > > /* we assume STATE_INITIAL here! */ > > > /* these lines kept for information only */ > > > if (sp->state[IDX_LCP] != STATE_INITIAL) > > > lcp.Close(sp); > > > #endif > > Layer is not in initial state, it is in starting state. > So this code should be executed here. The only > problem is that it references many internal defines > of if_spppsubr.c. Wouldn't it be easier to make > lcp_down if if_spppsubr.c smarter so it wouldn't > complain like it now does ? > [Note: 2 mails handled in one] In that case my suggestion is incorrect. Your patch is the correct way to do it. "Ari Suutari" writes: > I did some reading on PPP RFC (1661). The correct way for > physical layer to signal that it is no longer able to carry packet > is to use Down event. So I think that my original code was correct. > The problem is in sppp layer, which works otherwise ok > but prints out extraneous message. > > The PPP RFC doesn't say that it is legal to receive > Down event when LCP is in starting state but says > elsewhere that Down is the event to use by physical layer... I suppose. if_spppsubr.c is Jörg Wunsch's baby. We should ask him his opinion. I'm pretty sure that he's subscribed to this list. But I'll Cc: him. Jörg, any problem aith adding something like this to sppp_down_event? (not a real diff) case STATE_CLOSING: + case STATE_STARTING: sppp_cp_change_state(cp, sp, STATE_INITIAL); break; --- Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301241522.h0OFLwj1014253>