Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Aug 2016 14:21:46 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r304156 - in vendor-sys/illumos/dist/uts/common/fs/zfs: . sys
Message-ID:  <201608151421.u7FELkRp083794@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Mon Aug 15 14:21:46 2016
New Revision: 304156
URL: https://svnweb.freebsd.org/changeset/base/304156

Log:
  7235 remove unused func dsl_dataset_set_blkptr
  
  illumos/illumos-gate@bd56f80007857b960e0981ed0797ad8ec844a96b
  https://github.com/illumos/illumos-gate/commit/bd56f80007857b960e0981ed0797ad8ec844a96b
  
  https://www.illumos.org/issues/7235
    The function dsl_dataset_set_blkptr() is unused. We should remove it.
  
  Reviewed by: George Wilson <george.wilson@delphix.com>
  Reviewed by: Alex Reece <alex@delphix.com>
  Reviewed by: Prakash Surya <prakash.surya@delphix.com>
  Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
  Approved by: Robert Mustacchi <rm@joyent.com>
  Author: Matthew Ahrens <mahrens@delphix.com>

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_dataset.c
  vendor-sys/illumos/dist/uts/common/fs/zfs/sys/dsl_dataset.h

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_dataset.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_dataset.c	Mon Aug 15 14:21:10 2016	(r304155)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_dataset.c	Mon Aug 15 14:21:46 2016	(r304156)
@@ -1007,19 +1007,6 @@ dsl_dataset_get_blkptr(dsl_dataset_t *ds
 	return (&dsl_dataset_phys(ds)->ds_bp);
 }
 
-void
-dsl_dataset_set_blkptr(dsl_dataset_t *ds, blkptr_t *bp, dmu_tx_t *tx)
-{
-	ASSERT(dmu_tx_is_syncing(tx));
-	/* If it's the meta-objset, set dp_meta_rootbp */
-	if (ds == NULL) {
-		tx->tx_pool->dp_meta_rootbp = *bp;
-	} else {
-		dmu_buf_will_dirty(ds->ds_dbuf, tx);
-		dsl_dataset_phys(ds)->ds_bp = *bp;
-	}
-}
-
 spa_t *
 dsl_dataset_get_spa(dsl_dataset_t *ds)
 {

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/sys/dsl_dataset.h
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/sys/dsl_dataset.h	Mon Aug 15 14:21:10 2016	(r304155)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/sys/dsl_dataset.h	Mon Aug 15 14:21:46 2016	(r304156)
@@ -272,7 +272,6 @@ int dsl_dataset_snapshot_tmp(const char 
     minor_t cleanup_minor, const char *htag);
 
 blkptr_t *dsl_dataset_get_blkptr(dsl_dataset_t *ds);
-void dsl_dataset_set_blkptr(dsl_dataset_t *ds, blkptr_t *bp, dmu_tx_t *tx);
 
 spa_t *dsl_dataset_get_spa(dsl_dataset_t *ds);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608151421.u7FELkRp083794>