Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Feb 2017 16:52:21 +0000 (UTC)
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r313775 - head/sys/fs/devfs
Message-ID:  <201702151652.v1FGqLCk034403@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: trasz
Date: Wed Feb 15 16:52:21 2017
New Revision: 313775
URL: https://svnweb.freebsd.org/changeset/base/313775

Log:
  Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf.
  It's not a proper fix, but should be better than what we have now.
  Since it got broken some six months ago it results in an incredibly
  annoying and trivially reproducible panic every time eg an USB disk
  gets disconnected.
  
  MFC after:	2 weeks
  Sponsored by:	DARPA, AFRL

Modified:
  head/sys/fs/devfs/devfs_vnops.c

Modified: head/sys/fs/devfs/devfs_vnops.c
==============================================================================
--- head/sys/fs/devfs/devfs_vnops.c	Wed Feb 15 15:32:29 2017	(r313774)
+++ head/sys/fs/devfs/devfs_vnops.c	Wed Feb 15 16:52:21 2017	(r313775)
@@ -693,7 +693,7 @@ devfs_fsync(struct vop_fsync_args *ap)
 
 			error = vop_stdfsync(ap);
 			if (bo->bo_dirty.bv_cnt != 0 || error != 0)
-				panic("devfs_fsync: vop_stdfsync failed.");
+				printf("devfs_fsync: vop_stdfsync failed.");
 		}
 
 		return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702151652.v1FGqLCk034403>