Date: Tue, 12 Oct 2021 02:02:42 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Bernhard Fr??hlich <decke@freebsd.org> Cc: Max Brazhnikov <makc@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@freebsd.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@freebsd.org> Subject: Re: git: a90e961f4d19 - main - */*: Avoid extra CPE_VENDOR=kde by properly sorting USES Message-ID: <YWTswgVNWhRgt91f@FreeBSD.org> In-Reply-To: <CAE-m3X2o-nDLrvK4g8w0Mqsy5fXF2Pix1YR-TK=m-yrL2Du8JQ@mail.gmail.com> References: <202110111458.19BEw4xF062545@gitrepo.freebsd.org> <3067458.bT80LyP3VS@mercury> <CAE-m3X2o-nDLrvK4g8w0Mqsy5fXF2Pix1YR-TK=m-yrL2Du8JQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 11, 2021 at 09:43:51PM +0200, Bernhard Fr??hlich wrote: > On Monday, October 11, 2021, Max Brazhnikov wrote: > > On Mon, 11 Oct 2021 14:58:04 GMT Bernhard Froehlich wrote: > > > commit a90e961f4d19d53621612d1257a77a5635906ee0 > > > > > > */*: Avoid extra CPE_VENDOR=kde by properly sorting USES > > > > > > CPE_VENDOR=kde is already set in Uses/kde.mk so adding cpe after > > > kde in our USES line makes sure that it's picked up properly. > > > > I believe you shouldn't rely on USES order, it will be broken sooner > > or later. > > Doesn't matter much since CPE data is a moving target anyway. Max' point still stands in general. Sorting various things and knobs alphabetically not only brings neatness and consistency, but also helps to find hidden dependencies and unconvolute or record them properly. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YWTswgVNWhRgt91f>