Date: Sat, 17 Aug 2019 09:46:27 +0200 From: Gary Jennejohn <gljennjohn@gmail.com> To: John Baldwin <jhb@FreeBSD.org> Cc: current@freebsd.org Subject: Re: problem with LOCAL_MODULES Message-ID: <20190817094627.64358949@ernst.home> In-Reply-To: <e1010b9b-26a6-9ce6-873c-10e503dc2030@FreeBSD.org> References: <20190816120524.21b7fd19@ernst.home> <e1010b9b-26a6-9ce6-873c-10e503dc2030@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Aug 2019 17:37:56 -0700
John Baldwin <jhb@FreeBSD.org> wrote:
> On 8/16/19 3:05 AM, Gary Jennejohn wrote:
> > I tried to build a kernel today and it failed in modules-all even
> > though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by
> > jhb.
> >
> > That's wrong. It has to be LOCAL_MODULES=, otherwise
> > /sys/conf/kern.post.mk seems to conclude that there should be a
> > module under /usr/local/sys/modules with the name "".
>
> I think this will permit both versions to work:
>
> Index: sys/conf/kern.post.mk
> ===================================================================
> --- kern.post.mk (revision 351151)
> +++ kern.post.mk (working copy)
> @@ -76,6 +76,7 @@ modules-${target}:
> cd $S/modules; ${MKMODULESENV} ${MAKE} \
> ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> .endif
> +.if !empty(LOCAL_MODULES)
> .for module in ${LOCAL_MODULES}
> @${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
> @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
> @@ -83,6 +84,7 @@ modules-${target}:
> ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> .endfor
> .endif
> +.endif
> .endfor
>
> # Handle ports (as defined by the user) that build kernel modules
>
Nope, the same error as before with the patch applied and
LOCAL_MODULES="" .
--
Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190817094627.64358949>