Date: Mon, 20 Nov 2017 19:38:31 -0700 From: Alan Somers <asomers@freebsd.org> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: Ed Maste <emaste@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests Message-ID: <CAOtMX2j9hnuSzUd7AonQc%2BjdkjfPa-sgh6BOpDsUUNRD=vP1sg@mail.gmail.com> In-Reply-To: <CAJ5_RoBVigmMGWzucCQEcqMr_2q92xkPkUBtxBsb0KjgsJUisA@mail.gmail.com> References: <201711202255.vAKMt2nP014201@repo.freebsd.org> <CAPyFy2BDB5dVF_hURt9Xs4U4PzHW8KoL=6%2BEf0WGJgTxQSVaPw@mail.gmail.com> <CAOtMX2iot8LRW1VqN5UNAaF4p59hdMwN7NJVRqXwbk5mm1f8-g@mail.gmail.com> <CAJ5_RoBVigmMGWzucCQEcqMr_2q92xkPkUBtxBsb0KjgsJUisA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 20, 2017 at 6:48 PM, Benjamin Kaduk <bjkfbsd@gmail.com> wrote: > On Mon, Nov 20, 2017 at 7:36 PM, Alan Somers <asomers@freebsd.org> wrote: >> >> >> Are there any automated tools that care about the "Differential >> Revision" field? If so, they should be able to tell the difference >> between GitHub revisions and Phabricator revisions based on the URL. > > > > Yes, Phabricator itself uses the link to close out the review. > > >> >> Using "Differential Revision" instead of "Pull request" is handy, >> because it's part of the standard commit template, which encourages >> consistency. > > > As Warner says, we could just add a new thing to the template instead > of overloading an existing one for convenience. > > -Ben Okeedookee. Here you go: https://reviews.freebsd.org/D13179 https://reviews.freebsd.org/D13178 -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2j9hnuSzUd7AonQc%2BjdkjfPa-sgh6BOpDsUUNRD=vP1sg>