Date: Sun, 5 May 2013 23:32:13 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: freebsd-bugs@freebsd.org Cc: Andrew Romanenko <melanhit@gmail.com>, freebsd-geom@freebsd.org Subject: Re: kern/178359: [geom] [patch] geom_eli: support external metadata Message-ID: <CACdU%2Bf8agTBrAMGuhZyMg8SV3toCOcBY7z%2BV_QEUy0OtW=tqig@mail.gmail.com> In-Reply-To: <CACdU%2Bf_rzz8XUGnUQP8WsDLpTnC2rf5_7SVwMkp98k_Wigux=w@mail.gmail.com> References: <201305060054.r460sVBh004810@freefall.freebsd.org> <CACdU%2Bf_rzz8XUGnUQP8WsDLpTnC2rf5_7SVwMkp98k_Wigux=w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 5, 2013 at 10:51 PM, Scot Hetzel <swhetzel@gmail.com> wrote: > On Sun, May 5, 2013 at 7:54 PM, <linimon@freebsd.org> wrote: >> Old Synopsis: geom_eli: support external metadata >> New Synopsis: [geom] [patch] geom_eli: support external metadata >> >> Responsible-Changed-From-To: freebsd-bugs->freebsd-geom >> Responsible-Changed-By: linimon >> Responsible-Changed-When: Mon May 6 00:54:16 UTC 2013 >> Responsible-Changed-Why: >> Over to maintainer(s). >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=178359 > > I had a quick look at the patch and noticed that it is using -H for > init method, but -h for the attach, configure, setkey, delkey, resume, > resize, and dump methods. > > The patch also shows that it removes the -h option from the init > method. I looked at the -Current and release/9.1.0 sources for > geom_eli.8 and they don't have the -h option. I suspect it was a > local modification that was made before this patch was created. > My mistake, the -h option was in the geom_eli.c file, but only in the comment for the commands. According to the original commit: https://svnweb.freebsd.org/base?view=revision&revision=148456 The -h was never in the class_commands for the init method. Not sure what it was there for (maybe to display the usuage?). > It would be best that init, attach, configure, setkey, delkey, resume, > resize, and dump methods use the same option (-h or -H) to specify the > headerfile. > So for now it looks like using -H would be the better option for all these methods. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACdU%2Bf8agTBrAMGuhZyMg8SV3toCOcBY7z%2BV_QEUy0OtW=tqig>