Date: Tue, 10 Aug 2004 07:49:13 -0700 From: John-Mark Gurney <gurney_j@resnet.uoregon.edu> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mdioctl.h src/sys/modules/md Makefile src/sbin/mdconfig mdconfig.c Message-ID: <20040810144913.GO991@funkthat.com> In-Reply-To: <20040810122307.GA18408@ip.net.ua> References: <200408090645.i796jLUo046034@repoman.freebsd.org> <20040810122307.GA18408@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote this message on Tue, Aug 10, 2004 at 15:23 +0300:
> On Mon, Aug 09, 2004 at 06:45:21AM +0000, John-Mark Gurney wrote:
> > jmg 2004-08-09 06:45:21 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/sys mdioctl.h
> > sys/modules/md Makefile
> > sbin/mdconfig mdconfig.c
> > Log:
> > change the name of the md module, to g_md, introduce a define with the
> > name MD_MODNAME, and make mdconfig use this new define...
> >
> > Revision Changes Path
> > 1.33 +1 -1 src/sbin/mdconfig/mdconfig.c
> > 1.13 +1 -1 src/sys/modules/md/Makefile
> > 1.16 +1 -0 src/sys/sys/mdioctl.h
> >
> Why the change in the first place?
so that mdconfig does not try to load the md kernel module twice, and
cause your machine to panic.
With a recent commit of phk's to md that converts it to geom, he removed
the previous DECLARE_MODULE w/ the name of md, and so the md module was
no longer implementing the md module, only the g_md module. On my box
that is using mfs, mdconfig would then try to load the md module a
second time causing geom to panic.
Sorry, I should of included some of this information in the commit
message.
I then realized that since md is now a full on geom module, it should
be renamed to geom_md like all the other geom modules... I still need
to ask cvs@ to repo copy the module Makefiles into modules/geom/md...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040810144913.GO991>