Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Dec 2008 23:32:34 -0500
From:      Bruce Cran <bruce@cran.org.uk>
To:        Pyun YongHyeon <pyunyh@gmail.com>
Cc:        current@freebsd.org
Subject:   Re: RTL8102E (if_re) doesn't work with -current
Message-ID:  <20081218043234.GA26186@muon.cran.org.uk>
In-Reply-To: <20081217091934.GH66999@cdnetworks.co.kr>
References:  <4947E59A.8000408@cran.org.uk> <20081217005106.GA66999@cdnetworks.co.kr> <49486EDD.6060607@cran.org.uk> <20081217034155.GB66999@cdnetworks.co.kr> <494897CB.7000507@cran.org.uk> <20081217084633.GG66999@cdnetworks.co.kr> <20081217091934.GH66999@cdnetworks.co.kr>

next in thread | previous in thread | raw e-mail | index | archive | help

--J2SCkAp4GZ/dPZZf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 17, 2008 at 06:19:34PM +0900, Pyun YongHyeon wrote:
>=20
> Oops, please forget previous patch and use attached patch instead.
>=20
> Index: if_re.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- if_re.c	(revision 186214)
> +++ if_re.c	(working copy)
> @@ -2681,7 +2681,14 @@
>  	ifp->if_drv_flags |=3D IFF_DRV_RUNNING;
>  	ifp->if_drv_flags &=3D ~IFF_DRV_OACTIVE;
> =20
> -	sc->rl_flags &=3D ~RL_FLAG_LINK;
> +	/*
> +	 * XXX
> +	 * Since we don't request reset for rlphy(4), it's necessary
> +	 * to set initial (fake) link state. Otherwise re(4) wouldn't
> +	 * work as link state 'UP' event from mii(4) may not be
> +	 * delivered if the valid link was already established.
> +	 */
> +	sc->rl_flags |=3D RL_FLAG_LINK;
>  	sc->rl_watchdog_timer =3D 0;
>  	callout_reset(&sc->rl_stat_callout, hz, re_tick, sc);
>  }

With that patch applied (I kept the changes to rlphy.c too) the network is=
=20
now working again.  Thanks!

--=20
Bruce Cran

--J2SCkAp4GZ/dPZZf
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklJ0mIACgkQn4uvqcJsLfg+jwCeP483QkX73CUQVljeFwgwfLck
WwYAoLQT09gYpRoGQmTM94ykJpYA0M5O
=6U4X
-----END PGP SIGNATURE-----

--J2SCkAp4GZ/dPZZf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081218043234.GA26186>