Date: Mon, 21 May 2018 00:17:41 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Matthew Macy <mmacy@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r333924 - head/sys/fs/nfsclient Message-ID: <YTOPR0101MB095372585097BD0FAEC1D82FDD950@YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <CAPrugNoC8ggq_KVQxtRh_svZAaopQbt6-c91aob8mrBCYUU6oQ@mail.gmail.com> References: <201805200614.w4K6EC0L023252@repo.freebsd.org> <YTOPR0101MB0953F8019AA9DB979B5CE0D0DD960@YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM> <CAPrugNrfuG2Nts0XPnJvWZa6hC9a2Rr49w7Vp4Typ88RTq5UMw@mail.gmail.com>, <CAPrugNoC8ggq_KVQxtRh_svZAaopQbt6-c91aob8mrBCYUU6oQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm not in a situation where I can use gcc, but if you email me the list of warnings, I can look at them. rick ________________________________________ From: Matthew Macy <mmacy@freebsd.org> Sent: Sunday, May 20, 2018 7:16:31 PM To: Rick Macklem Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r333924 - head/sys/fs/nfsclient Actually if you could clean up the NFS code that would be great. It's _full_ of set but not used warnings. And anyone else reading this if you could clean up other areas. I've mostly cleaned up kern / net / netinet / iflib drivers. both WITHOUT_FORMAT_EXTENSIONS=3D XCC=3D/usr/local/bin/gcc8 make -j<ncpu> build= kernel and WITHOUT_FORMAT_EXTENSIONS=3D XCC=3D/usr/local/bin/gcc8 make -j<ncpu> buildkernel KERNCONF=3DGENERIC-NODEBUG Thanks. On Sun, May 20, 2018 at 4:09 PM, Matthew Macy <mmacy@freebsd.org> wrote: > gcc8 > > On Sun, May 20, 2018 at 15:14 Rick Macklem <rmacklem@uoguelph.ca> wrote: >> >> Matt Macy wrote: >> >Author: mmacy >> >Date: Sun May 20 06:14:12 2018 >> >New Revision: 333924 >> >URL: https://svnweb.freebsd.org/changeset/base/333924 >> > >> >Log: >> > nfsclient: warnings cleanups >> Just wondering what compiler you are using. I haven't seen warnings for >> these? >> FYI, for the first two cases, ncookie is always set before it is used. >> For the third, "rflags" is set but not used. I sometimes leave code like >> this in >> the tree since I might need those argument flags later and might not >> remember >> how to get them. In this case, similar code in other functions set >> "rflags" in the >> same way, so it shouldn't be hard to crib the assignment from there. >> As such, I don't have a problem with deleting the code. >> >> rick >> ... the commit patch ... >> Modified: >> head/sys/fs/nfsclient/nfs_clcomsubs.c >> head/sys/fs/nfsclient/nfs_clrpcops.c >> >> Modified: head/sys/fs/nfsclient/nfs_clcomsubs.c >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/fs/nfsclient/nfs_clcomsubs.c Sun May 20 05:59:42 2018 >> (r333923) >> +++ head/sys/fs/nfsclient/nfs_clcomsubs.c Sun May 20 06:14:12 2018 >> (r333924) >> @@ -354,7 +354,7 @@ nfsm_uiombuflist(struct uio *uiop, int siz, struct m= bu >> char *uiocp; >> struct mbuf *mp, *mp2, *firstmp; >> int xfer, left, mlen; >> - int uiosiz, clflg, rem; >> + int uiosiz, clflg; >> char *tcp; >> >> KASSERT(uiop->uio_iovcnt =3D=3D 1, ("nfsm_uiotombuf: iovcnt !=3D= 1")); >> @@ -363,7 +363,6 @@ nfsm_uiombuflist(struct uio *uiop, int siz, struct m= bu >> clflg =3D 1; >> else >> clflg =3D 0; >> - rem =3D NFSM_RNDUP(siz) - siz; >> if (clflg !=3D 0) >> NFSMCLGET(mp, M_WAITOK); >> else >> >> Modified: head/sys/fs/nfsclient/nfs_clrpcops.c >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/fs/nfsclient/nfs_clrpcops.c Sun May 20 05:59:42 2018 >> (r333923) >> +++ head/sys/fs/nfsclient/nfs_clrpcops.c Sun May 20 06:14:12 2018 >> (r333924) >> @@ -2845,7 +2845,7 @@ nfsrpc_readdir(vnode_t vp, struct uio *uiop, >> nfsuint64 >> KASSERT(uiop->uio_iovcnt =3D=3D 1 && >> (uio_uio_resid(uiop) & (DIRBLKSIZ - 1)) =3D=3D 0, >> ("nfs readdirrpc bad uio")); >> - >> + ncookie.lval[0] =3D ncookie.lval[1] =3D 0; >> /* >> * There is no point in reading a lot more than uio_resid, howev= er >> * adding one additional DIRBLKSIZ makes sense. Since uio_resid >> @@ -3288,6 +3288,7 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, >> nfsui >> KASSERT(uiop->uio_iovcnt =3D=3D 1 && >> (uio_uio_resid(uiop) & (DIRBLKSIZ - 1)) =3D=3D 0, >> ("nfs readdirplusrpc bad uio")); >> + ncookie.lval[0] =3D ncookie.lval[1] =3D 0; >> timespecclear(&dctime); >> *attrflagp =3D 0; >> if (eofp !=3D NULL) >> @@ -6943,6 +6944,7 @@ nfsrv_parseug(struct nfsrv_descript *nd, int dogrp= , >> ui >> >> NFSM_DISSECT(tl, uint32_t *, NFSX_UNSIGNED); >> len =3D fxdr_unsigned(uint32_t, *tl); >> + str =3D NULL; >> if (len > NFSV4_OPAQUELIMIT) { >> error =3D NFSERR_BADXDR; >> goto nfsmout; >> @@ -7244,7 +7246,6 @@ nfsrpc_createlayout(vnode_t dvp, char *name, int >> namel >> struct nfsclsession *tsep; >> nfsattrbit_t attrbits; >> nfsv4stateid_t stateid; >> - uint32_t rflags; >> struct nfsmount *nmp; >> >> nmp =3D VFSTONFS(dvp->v_mount); >> @@ -7327,7 +7328,6 @@ nfsrpc_createlayout(vnode_t dvp, char *name, int >> namel >> stateid.other[0] =3D *tl++; >> stateid.other[1] =3D *tl++; >> stateid.other[2] =3D *tl; >> - rflags =3D fxdr_unsigned(u_int32_t, *(tl + 6)); >> nfsrv_getattrbits(nd, &attrbits, NULL, NULL); >> NFSM_DISSECT(tl, u_int32_t *, NFSX_UNSIGNED); >> deleg =3D fxdr_unsigned(int, *tl); >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTOPR0101MB095372585097BD0FAEC1D82FDD950>