Date: Tue, 11 Sep 2001 15:10:27 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: =?koi8-r?Q?S=F8ren_Schmidt?= <sos@freebsd.dk> Cc: =?koi8-r?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/burncd burncd.8 burncd.c Message-ID: <20010911151027.B47073@sunbay.com> In-Reply-To: <200109111208.f8BC8Si07878@freebsd.dk>; from sos@freebsd.dk on Tue, Sep 11, 2001 at 02:08:28PM %2B0200 References: <20010911150539.A47073@sunbay.com> <200109111208.f8BC8Si07878@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 11, 2001 at 02:08:28PM +0200, Søren Schmidt wrote:
> It seems Ruslan Ermilov wrote:
> [ Charset KOI8-R unsupported, converting... ]
> > On Tue, Sep 11, 2001 at 04:52:50AM -0700, S?ren Schmidt wrote:
> > > sos 2001/09/11 04:52:50 PDT
> > >
> > > Modified files:
> > > usr.sbin/burncd burncd.8 burncd.c
> > > Log:
> > > Fixes from Ruslan Ermilov:
> > >
> > [...]
> > > 4. Nuke the prog_name variable burncd.c, use getprogname(3).
^^^^^^^^^^^^^^^^^^
Here's what I've complained to. The code just nukes the variable.
> > >
> > Uhh, here's what I actually said:
> >
> > : The patch for burncd.c also nukes the prog_name variable.
> > : If it's at all needed (and this contradicts what style(9)
> > : says), please use getprogname(3) instead.
> >
> > What I meant was is that if you need that prog_name variable,
> > you should initialize it from getprogname(3), not from argv[0].
>
> Yep, but I dont need it for anything but the usage() stuff...
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010911151027.B47073>