Date: Thu, 25 Mar 1999 02:00:02 -0800 (PST) From: Tom Hukins <tom@eborcom.com> To: freebsd-ports@FreeBSD.org Subject: Re: ports/10770: New Port for kmp3 Message-ID: <199903251000.CAA61283@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/10770; it has been noted by GNATS. From: Tom Hukins <tom@eborcom.com> To: obonilla@fisicc-ufm.edu Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: ports/10770: New Port for kmp3 Date: Wed, 24 Mar 1999 22:08:33 +0000 Oscar, thanks for submitting this port. There are a few problems with it, which I explain below: On Wed, Mar 24, 1999 at 09:07:05AM -0600, obonilla@fisicc-ufm.edu wrote: > > >Synopsis: New Port for kmp3 (a mp3 player for the KDE) > > X# New ports collection makefile for: kmpg > X# Version required: 0.4.3a > X# Date created: 23 May 1998 > X# Whom: Hans Petter Bieker <hanspb@persbraten.vgs.no> Each one of the lines above is incorrect. The "Making a port yourself" section of the Handbook explains how this should be done under the "Quick porting section". > X# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $ A new port should be submitted with $Id$. Again, this is covered in the Handbook. I have tidied up this port (patch below), fixing the things mentioned above, using MASTER_SITE_KDE and sorting pkg/PLIST alphabetically. The kmp3/amp section of the port still fails to honour CFLAGS, however. I haven't fixed this. Tom diff -ruN kmp3.old/Makefile kmp3/Makefile --- kmp3.old/Makefile Wed Mar 24 21:58:50 1999 +++ kmp3/Makefile Wed Mar 24 20:44:13 1999 @@ -1,14 +1,15 @@ # New ports collection makefile for: kmpg -# Version required: 0.4.3a -# Date created: 23 May 1998 -# Whom: Hans Petter Bieker <hanspb@persbraten.vgs.no> +# Version required: 0.2.2 +# Date created: 24 May 1999 +# Whom: Tom Hukins <tom@eborcom.com> # -# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $ +# $Id$ # DISTNAME= kmp3-0.2.2 CATEGORIES= audio kde -MASTER_SITES= ftp://ftp.kde.org/pub/kde/stable/1.1/apps/multimedia/sound/ +MASTER_SITES= ${MASTER_SITE_KDE} +MASTER_SITE_SUBDIR= stable/1.1/apps/multimedia/sound/ MAINTAINER= obonilla@fisicc-ufm.edu diff -ruN kmp3.old/pkg/PLIST kmp3/pkg/PLIST --- kmp3.old/pkg/PLIST Wed Mar 24 21:58:50 1999 +++ kmp3/pkg/PLIST Wed Mar 24 20:58:24 1999 @@ -1,14 +1,14 @@ bin/kmp3 bin/kmp3player share/applnk/Multimedia/KMp3.kdelnk -share/icons/kmp3.xpm -share/icons/mini/kmp3.xpm share/apps/kmp3/pics/dock_idle.xpm share/apps/kmp3/pics/dock_playing.xpm share/apps/kmp3/pics/logo.xpm -share/locale/fr/LC_MESSAGES/kmp3.mo +share/icons/kmp3.xpm +share/icons/mini/kmp3.xpm share/locale/de/LC_MESSAGES/kmp3.mo share/locale/es/LC_MESSAGES/kmp3.mo +share/locale/fr/LC_MESSAGES/kmp3.mo share/locale/is/LC_MESSAGES/kmp3.mo @dirrm share/apps/kmp3/pics @dirrm share/apps/kmp3 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903251000.CAA61283>