Date: Thu, 28 Sep 2017 11:07:35 -0600 From: Warner Losh <imp@bsdimp.com> To: Andriy Gapon <avg@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: lua in zfs Message-ID: <CANCZdfo-hUXk_ftXja%2BGQccFzVJLq=NLM062LJ6E3OqGJzFXTA@mail.gmail.com> In-Reply-To: <cb9ecefd-49e5-f6b9-5fa6-9ff94139050b@FreeBSD.org> References: <ae7a34af-4c91-daae-e917-b98ac7fb69d9@FreeBSD.org> <CANCZdfqocwEArqntzUdwBufxa%2BNANHs6VdKJrRFwGHT8HpaFyw@mail.gmail.com> <fd8098c7-37dd-e66a-e528-2668203381a5@FreeBSD.org> <CANCZdfp7=_SyD4SovOFuA1hq8cQHOy%2BGQ8EbtnDZ5LnFNQuE8Q@mail.gmail.com> <1506614109.31939.20.camel@freebsd.org> <c66955fd-957f-ac18-b220-f0e85d5c72b7@FreeBSD.org> <cb9ecefd-49e5-f6b9-5fa6-9ff94139050b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 28, 2017 at 10:50 AM, Andriy Gapon <avg@freebsd.org> wrote: > On 28/09/2017 19:44, Andriy Gapon wrote: > > On 28/09/2017 18:55, Ian Lepore wrote: > >> Iirc, the big difference between 5.2.x and 5.3 is that the latter added > >> support for integers. It seems like that would be a good thing, in the > >> kernel. > > > > I am sure that the ZFS Lua represents numbers as integers and has no > floating > > point support at all. > > > Some more info: > https://github.com/illumos/illumos-gate/blob/master/usr/ > src/uts/common/fs/zfs/lua/README.zfs Reading this strongly suggests to me that we're going to have two versions of lua in the tree then: 1) This version is a modified version of 5.2.4 2) Significant changes have been made to harden this interpreter, which won't be in 5.3.0 3) A number of APIs have been removed, which makes it difficult to use as a general purpose thing. So I think that you should go ahead and import it. The level of work for my request is very high, and significantly diverges us from upstream. It's unfortunate that we'll have two versions. But this isn't really pure lua but a variant maybe better described as lua-zfs. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo-hUXk_ftXja%2BGQccFzVJLq=NLM062LJ6E3OqGJzFXTA>