Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 01 Oct 2014 10:14:54 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-current@freebsd.org
Subject:   [PATCH] Fix OACTIVE for an(4)
Message-ID:  <2113392.UOaBFTpimf@ralph.baldwin.cx>

next in thread | raw e-mail | index | archive | help
This small patch correctly sets OACTIVE when an(4) gets backed up.  Right now 
I believe it will never set the flag.  It is only an optimization, it should 
not affect correctness.

Index: an/if_an.c
===================================================================
--- an/if_an.c  (revision 270968)
+++ an/if_an.c  (working copy)
@@ -2906,11 +2906,11 @@
                CSR_WRITE_2(sc, AN_INT_EN(sc->mpi350), AN_INTRS(sc->mpi350));
        }
 
-       if (m0 != NULL)
+       if (sc->an_rdata.an_tx_prod != idx) {
                ifp->if_drv_flags |= IFF_DRV_OACTIVE;
+               sc->an_rdata.an_tx_prod = idx;
+       }
 
-       sc->an_rdata.an_tx_prod = idx;
-
        return;
 }

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2113392.UOaBFTpimf>