Date: Mon, 10 Nov 2014 21:07:27 +0400 From: Andrej Zverev <az@freebsd.org> To: Philippe Audeoud <jadawin@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r372397 - head/devel/p5-Config-Any Message-ID: <CAD5bB%2Bix3QVimmS1CdR7s7FoU4okE6iGGPqKby24GO1hYjJZZg@mail.gmail.com> In-Reply-To: <201411101505.sAAF53Kj011471@svn.freebsd.org> References: <201411101505.sAAF53Kj011471@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, i did some later changes in this port. I don't agree with this patch, since it only adds depend based on fact what 'make test' target doesn't work for submitter, but our ports tree and this port itself don't support 'make test'. While I agree with fact what 'Module::Pluggable' already deprecated in 5.20, we need depend on it explicit. I hope now my 'why i did it' is more clear :-) On Mon, Nov 10, 2014 at 6:05 PM, Philippe Audeoud <jadawin@freebsd.org> wrote: > Author: jadawin > Date: Mon Nov 10 15:05:02 2014 > New Revision: 372397 > URL: https://svnweb.freebsd.org/changeset/ports/372397 > QAT: https://qat.redports.org/buildarchive/r372397/ > > Log: > - Add p5-Module-Pluggable as depends > - Add licence > > PR: ports/194926 > Submitted by: Henk van Oers <hvo.pm at xs4all.nl> > > Modified: > head/devel/p5-Config-Any/Makefile > > Modified: head/devel/p5-Config-Any/Makefile > > ============================================================================== > --- head/devel/p5-Config-Any/Makefile Mon Nov 10 14:23:12 2014 > (r372396) > +++ head/devel/p5-Config-Any/Makefile Mon Nov 10 15:05:02 2014 > (r372397) > @@ -3,6 +3,7 @@ > > PORTNAME= Config-Any > PORTVERSION= 0.24 > +PORTREVISION= 1 > CATEGORIES= devel perl5 > MASTER_SITES= CPAN > PKGNAMEPREFIX= p5- > @@ -10,7 +11,11 @@ PKGNAMEPREFIX= p5- > MAINTAINER= perl@FreeBSD.org > COMMENT= Load class configuration data from a number of file formats > > -BUILD_DEPENDS= p5-Config-General>=2.47:${PORTSDIR}/devel/p5-Config-General > +LICENSE= ART10 GPLv1 > +LICENSE_COMB= dual > + > +BUILD_DEPENDS= > p5-Config-General>=2.47:${PORTSDIR}/devel/p5-Config-General \ > + > p5-Module-Pluggable>=0:${PORTSDIR}/devel/p5-Module-Pluggable > RUN_DEPENDS:= ${BUILD_DEPENDS} > > OPTIONS_DEFINE= INI JSON XML YAML > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2Bix3QVimmS1CdR7s7FoU4okE6iGGPqKby24GO1hYjJZZg>