Date: Mon, 25 Mar 2013 18:31:28 +0400 From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: Eric van Gyzen <eric@vangyzen.net> Cc: stable@FreeBSD.org Subject: Re: [patch] IPMI KCS can drop the lock while servicing a request Message-ID: <51505FC0.3040709@FreeBSD.org> In-Reply-To: <514F8061.7070206@FreeBSD.org> References: <514E6ED8.9040305@vangyzen.net> <514F8061.7070206@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25.03.2013 02:38, Alexander V. Chernikov wrote: > On 24.03.2013 07:11, Eric van Gyzen wrote: >> At work, we discovered that our application's IPMI thread would often >> use a lot of CPU time. The KCS thread uses DELAY to wait for the BMC, so >> it can run without sleeping for a "long" time with a slow BMC. It also >> holds the ipmi_softc.ipmi_lock during this time. When using adaptive >> mutexes, an application thread that wants to operate on the >> ipmi_pending_requests list will also spin during this same time. > We suffer from the same problem, too. >> >> We see no reason that the KCS thread needs to hold the lock while >> servicing a request. We've been running with the attached patch for a > Well, this seems to be true. I'll try to commit something like this > patch in several days. Done in r248705. > >> few months, with no ill effects. >> >> Eric >> >> >> _______________________________________________ >> freebsd-stable@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-stable >> To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" > > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" > -- WBR, Alexander
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51505FC0.3040709>