Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Apr 2011 23:48:19 -0400
From:      "Jason J. Hellenthal" <jhell@DataIX.net>
To:        "Andrey V. Elsukov" <ae@freebsd.org>
Cc:        FreeBSD Current <freebsd-current@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, freebsd-geom@freebsd.org
Subject:   Re: A replacement for GEOM_LABEL's gpt/gptid
Message-ID:  <20110429034819.GA38949@DataIX.net>
In-Reply-To: <4DB7C7B7.9020201@FreeBSD.org>
References:  <4DB54F40.8050608@FreeBSD.org> <4DB7C7B7.9020201@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Andrey,

Great work, thank you. I have a little destraught about this over the
years since its inception with having just a label class for itself. Now
that this has all be properly tested it seems like a good idea to me to
split them up into their respective sections as you have done.

Now with the following I have some insight and question of if these
sysctls are really needed.

>> The patch is here:
>> http://people.freebsd.org/~ae/gpart_labels.diff
>
>I updated the patch, it is in the same location.
>I turned off glabel's gpt/gpid support and added loader tunables:
>
>kern.geom.part_label.apm.enable
>kern.geom.part_label.gpt.enable
>kern.geom.part_label.gptid.enable
>kern.geom.part_label.pc98.enable
>

As I see from the patch listed above, you have properly turned off the
support of these in the label class to move them to the consumers that
they are actually used in.

With that said, I do not understand and cant seem to wrap my mind around
why there needs to be a compatibility layer to provide both a sysctl for
what you have done and the old sysctl.

Why if this is only going to be used by the class where it is only
enabled do we need two sysctl ?

Can we not just keep them under the same OID they are under now ? It is
just a label after all and I dont see a need for renaming the sysctl.

>Also for compatibility glabel's tunables still here:
>
>kern.geom.label.gpt.enable
>kern.geom.label.gptid.enable
>
>So, if you have them in your loader.conf and want to have gpt/gptid labels,
>you should remove them from loader.conf.
>Also now they are only loader tunables and they can not be changed in runt=
ime.
>
>If there will no objections i am planning to commit patch in this weekend.
>
>


Anyway, thank you for you time.

--=20

 Regards, (jhell)
 Jason Hellenthal


--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)
Comment: http://bit.ly/0x89D8547E

iQEcBAEBAgAGBQJNujUCAAoJEJBXh4mJ2FR+wPIIAJprZxl1Kwv0IJLyLPEnKqIj
IaSj5887jCWU6sJSHiBEvuTqSI/BfnZg9fzF27kHn8+4BofkXvuappVNFSBD4bPD
lzgdQVnbO/xsDmE5NNs2Zvms38gr2K3YQGVABxKPJnA7LXhVW0qkFtUXxONOPE/i
mCMUNmWS5JJXZmgvWPpVWotUabBJ1gL0bYCoSPADIki860CbgCbFtEv6ZwTSUldk
6maevcM18FP4S7E3FIOOlUrtbPlHuQVPbOAASGA+6dDXKOo90TbNrprtI2glGKFe
fJbEW9jJ0eNx45ZirMHCKCoHNBaHFBRcJmAHe0Z57VSY3Z7GJ8sEHaR16tV9Id0=
=X5Ti
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110429034819.GA38949>