Date: Tue, 16 Aug 2016 16:57:05 +0200 From: Ed Schouten <ed@nuxi.nl> To: Emmanuel Vadot <manu@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304221 - head/sys/boot/efi/boot1 Message-ID: <CABh_MK=NxcfMsVogF%2BEW_HvHvBNiKJ6wG8szCkC5jwbTsw8NMw@mail.gmail.com> In-Reply-To: <201608161423.u7GENZJi021956@repo.freebsd.org> References: <201608161423.u7GENZJi021956@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Emmanuel, 2016-08-16 16:23 GMT+02:00 Emmanuel Vadot <manu@freebsd.org>: > Author: manu > Date: Tue Aug 16 14:23:35 2016 > New Revision: 304221 > URL: https://svnweb.freebsd.org/changeset/base/304221 > > Log: > Use %ju modifier for u_int64_t and %jd modifier for off_t. > off_t is long long on arm32 and long on amd64 I think both of these should be solved differently: - For uint64_t, you can use <inttypes.h>'s PRIu64 in the formatting string. In kernel space, I suspect you need to use something like <machine/inttypes.h>. - For off_t, it's all right to print it with %jd, but then be sure to also add a cast to the argument itself. It may not necessarily be equal to an intmax_t. -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MK=NxcfMsVogF%2BEW_HvHvBNiKJ6wG8szCkC5jwbTsw8NMw>