Date: Wed, 6 Feb 2002 06:29:49 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: Bruce Evans <bde@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: RE: cvs commit: src/sys/i386/i386 db_interface.c Message-ID: <20020206061908.G260-100000@gamplex.bde.org> In-Reply-To: <XFMail.020205000132.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 5 Feb 2002, John Baldwin wrote: > On 30-Jan-02 Bruce Evans wrote: > > bde 2002/01/30 10:23:32 PST > > > > Modified files: > > sys/i386/i386 db_interface.c > > Log: > > Backed out the last vestiges of rev.1.51. Don't enter a critical > > region in Debugger(), since rev.1.468 of machdep.c does this better. > > Other cosmetic backouts. > > Err, have you tested this? In my tests locally this still doesn't work > properly which is why I haven't committed it. :( PS: perhaps you are thinking of the flag in Debugger(). That is fundamentally broken too. It just protects against multiple entries to the debugger when the first entry is via the console debugger key. Try the following: - enter ddb using the key - hit the key again. No problem since the flag is set. - single step until the flag is unset - hit the key again. This causes a fine mess. The same thing mess happens when you enter ddb via a breakpoint and hit the key, except the console driver is not reentered then (unless the breakpoint is in the console driver). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020206061908.G260-100000>