Date: Wed, 26 Feb 2014 13:20:17 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Justin Hibbits <jrh29@alumni.cwru.edu> Cc: FreeBSD Current <freebsd-current@freebsd.org>, glebius@freebsd.org Subject: Re: Build failure on PowerPC in pf Message-ID: <20140226212017.GY92037@funkthat.com> In-Reply-To: <CAHSQbTC2Cy1KE3itH1B0N6e=J2qKE59sqeycV8CxrUzVUh86XA@mail.gmail.com> References: <CAHSQbTAT4qkf_rGvUVqOsxT5OvxZYbhuavrrp4GNieA6Pt6-UQ@mail.gmail.com> <CAHSQbTC2Cy1KE3itH1B0N6e=J2qKE59sqeycV8CxrUzVUh86XA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Justin Hibbits wrote this message on Wed, Feb 26, 2014 at 11:12 -0800:
> On Wed, Feb 26, 2014 at 10:32 AM, Justin Hibbits <jrh29@alumni.cwru.edu> wrote:
> > Building on PowerPC I see the following failure:
> >
> > cc1: warnings being treated as errors
> >
> > /home/chmeee/freebsd/head/sys/modules/pf/../../netpfil/pf/pf_ioctl.c:
> > In function 'pfioctl':
> > /home/chmeee/freebsd/head/sys/modules/pf/../../netpfil/pf/pf_ioctl.c:1357:warning:
> > cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > /home/chmeee/freebsd/head/sys/modules/pf/../../netpfil/pf/pf_ioctl.c:1359:warning:
> > cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > /home/chmeee/freebsd/head/sys/modules/pf/../../netpfil/pf/pf_ioctl.c:1361:warning:
> > cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >
> > struct pf_rule has counter_u64_t entries, which are actually pointers
> > to uint64_t's. These pointers get assigned from the result of
> > counter_u64_fetch(), which returns a uint64_t. Looks to me like
> > there's a bug in here, but I have no idea what to do to fix it. And
> > I'm surprised this hasn't been reported against other 32-bit
> > architectures.
>
> Replying to myself, it looks like this was broken by r261882.
This comment says it all:
1352 glebius 261882 /*
1353 * XXXGL: this is what happens when internal kernel
1354 * structures are used as ioctl API structures.
1355 */
So, one way could be to use a union for the states:
union {
struct {
counter_u64_t states_cur;
counter_u64_t states_tot;
counter_u64_t src_nodes;
} k;
struct {
uint64_t states_cur;
uint64_t states_tot;
uint64_t src_nodes;
} u;
} u;
The other option is to cast through uintptr_t...
Even though it'd make the code a bit more ugly, I'd vote for the union,
since it's designed for what the code is trying to do...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140226212017.GY92037>