Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Aug 2013 21:56:36 +0200
From:      Hans Petter Selasky <hans.petter.selasky@bitfrost.no>
To:        Juergen Lock <nox@jelal.kn-bremen.de>
Cc:        "freebsd-multimedia@freebsd.org" <freebsd-multimedia@freebsd.org>, Srinivas Kandagatla <srinivas.kandagatla@st.com>
Subject:   Re: New version of webcamd [3.11.0.1] ready for testing
Message-ID:  <520E83F4.6010307@bitfrost.no>
In-Reply-To: <20130816183810.GA16711@triton8.kn-bremen.de>
References:  <51A10BD5.1050107@bitfrost.no> <zarafa.520e5885.7648.5a3ce2f304daebfb@mail.lockless.no> <20130816183810.GA16711@triton8.kn-bremen.de>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Srinivas,

Can you submit the patch from Juergen? Thank you!

 >   Ah indeed that is better, now technisat-usb2 works again, including
> it's remote. :)  Here is the patch:
>
> --- media_tree/drivers/media/rc/rc-main.c.orig
> +++ media_tree/drivers/media/rc/rc-main.c
> @@ -707,7 +707,7 @@ int rc_open(struct rc_dev *rdev)
>   		return -EINVAL;
>
>   	mutex_lock(&rdev->lock);
> -	if (!rdev->users++)
> +	if (!rdev->users++ && rdev->open != NULL)
>   		rval = rdev->open(rdev);
>
>   	if (rval)
> @@ -731,7 +731,7 @@ void rc_close(struct rc_dev *rdev)
>   	if (rdev) {
>   		mutex_lock(&rdev->lock);
>
> -		 if (!--rdev->users)
> +		 if (!--rdev->users && rdev->close != NULL)
>   			rdev->close(rdev);
>
>   		mutex_unlock(&rdev->lock);
>> --HPS
>>
>   And now I also tested rtl28xxu, af9015, af9035, ati_remote, mceusb,
> uvc, gspca and they also all worked as before.
>
>   Thanx!
> 	Juergen

I'll wait a bit for the patch to reach V4L GIT and then I'll roll 
another tarball!

Thanks Juergen!

--HPS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?520E83F4.6010307>