Date: Mon, 17 Oct 2011 23:30:33 -0400 From: Glen Barber <gjb@FreeBSD.org> To: freebsd-www@FreeBSD.org Subject: Call For Review: PR www/91539 (FreeBSD web site renders very badly) Message-ID: <4E9CF2D9.7000900@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig86466A6E327B381863C6150B Content-Type: multipart/mixed; boundary="------------020402000301020809000107" This is a multi-part message in MIME format. --------------020402000301020809000107 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi all, I'd really like to make sure this PR does not have anymore anniversaries.= The problem with the current CSS layout is this: - When a user visiting FreeBSD.org using a browser with non-default font sizes (higher font sizes than the default), the site rendering becomes quite horrible - Due to the static sizing of the elements in the site, identifying a "one size fits all" fix for the site is near impossible; as a result, this PR has left our users of non-default font sizes agonizingly dealing with the poor rendering The attached patch does the following: - In layout.css, change the #HEADERLOGOLEFT and #HEADERLOGORIGHT IDs from a margin of 0px to a margin of -4%; this allows the logo DIV tags to adjust as needed. Otherwise, the #HEADERLOGORIGHT ID gets "pushed" down into the menu bar. The -4% margin allows the header content to remain as it is intended, for default font sizes up to 16pt. - In navigation.css, change the #MENU ID width from 100% to 122%. This allows the font size to be increased up to 16pt, without the "Foundation" link being pushed down into the body of the page. A side effect of this change causes a scrollbar to appear (to scroll left and right); though, this, in my opinion, is far less intrusive than the alternative. - Again, uses negative margins, similar to the reason above, so the actual content expands further beyond its limits, though without causing unwanted side effects. In addition to the header content above, ensures the content stays within the intended area, up to 16pt font. Output of the build can be found here: http://www.glenbarber.us/FreeBSD-pr91539/ I believe (and feedback thus far also suggests) it is an improvement over the issues pointed out in the original PR, such as the following screenshot: http://gallery.bsdforen.de/albums/userpics/12094/freebsd-org.png Feedback would be appreciated. Unless there are objections, I'd like to commit this change Sunday. Regards, Glen --=20 Glen Barber | gjb@FreeBSD.org FreeBSD Documentation Project --------------020402000301020809000107 Content-Type: text/plain; name="pr91539-css.diff.txt" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="pr91539-css.diff.txt" Index: en/layout/css/layout.css =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/dcvs/www/en/layout/css/layout.css,v retrieving revision 1.12 diff -u -r1.12 layout.css --- en/layout/css/layout.css 12 Jun 2011 08:45:47 -0000 1.12 +++ en/layout/css/layout.css 18 Oct 2011 02:54:20 -0000 @@ -40,7 +40,7 @@ border: 0px; padding: 0px; top: 0px; - margin: 0px; + margin-left: -4%; float: left; } =20 @@ -51,8 +51,8 @@ #HEADERLOGORIGHT, #headerlogoright { position: relative; border: 0px; - padding: 0px; - margin: 0px; + padding-left: 0px; + margin-right: -4%; float: right; } =20 Index: en/layout/css/navigation.css =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/dcvs/www/en/layout/css/navigation.css,v retrieving revision 1.7 diff -u -r1.7 navigation.css --- en/layout/css/navigation.css 6 Jul 2009 22:09:22 -0000 1.7 +++ en/layout/css/navigation.css 18 Oct 2011 02:54:20 -0000 @@ -74,11 +74,14 @@ /* New drop-down menu implementation */ =20 #MENU { - width: 100%; + width: 122%; float: left; height: 29px; font-size: 0.9em; - margin: 5px 0 2px 0; + clear: both; + margin-left: -1%; + margin-right: -5%; + margin-top: 5px; font-weight: bold; } =20 --------------020402000301020809000107-- --------------enig86466A6E327B381863C6150B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) iQEcBAEBCAAGBQJOnPLfAAoJEFJPDDeguUajro4H/1UMF2TwddCJkf+0NZU4EmLa 6yJ7pGwNg1lF9NCYlxnbhv3XMBvPILS6nqdiv4HNECcF4nlUEUnaeHe+NfNfgnz1 w2gk2M2Ykb4ByNnbQt3Y29CxlhjHY5uge+9OYBX/6yPqxAPBITQ1a3MNKUqbZnVP M0vQc0zDkyX3RmOuRo1PwYwPDhZzkiOMIJPDZhaC4R/yiAhK6klox5RTmu1fy607 un1OYHcHWXkbEIZcVAqU95bNrwkqrf1GK3KCHUsfsl6Y7QRfEOEnoWLSWUKWoCWG 9lzauv8gaNxVL9hHlW5glXJxhCaaRF4e/TY4+XQp5ca0M5lW2XFzGx3+pGYU5oU= =Jnrg -----END PGP SIGNATURE----- --------------enig86466A6E327B381863C6150B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E9CF2D9.7000900>